util/BitReverse: generate table with constexpr function

Get rid of the macro hell.

src/util/BitReverse.cxx

@@ -19,13 +19,13 @@
 
 #include "BitReverse.hxx"
 
-/**
- * @see http://graphics.stanford.edu/~seander/bithacks.html#BitReverseTable
- */
-const uint8_t bit_reverse_table[256] =
+static constexpr BitReverseTable
+GenerateBitReverseTable() noexcept
 {
-#define R2(n)     n,     n + 2*64,     n + 1*64,     n + 3*64
-#define R4(n) R2(n), R2(n + 2*16), R2(n + 1*16), R2(n + 3*16)
-#define R6(n) R4(n), R4(n + 2*4 ), R4(n + 1*4 ), R4(n + 3*4 )
-    R6(0), R6(2), R6(1), R6(3)
-};
+	BitReverseTable table{};
+	for (unsigned i = 0; i < 256; ++i)
+		table.data[i] = BitReverseMultiplyModulus(i);
+	return table;
+}
+
+const BitReverseTable bit_reverse_table = GenerateBitReverseTable();