oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

eliminate g_error() usage

Browse Source 
Replaced all occurrences of g_error() with MPD_ERROR() located in a new header
file 'mpd_error.h'. This macro uses g_critical() to print the error message
and then exits gracefully in contrast to g_error() which would internally call
abort() to produce a core dump.

The macro name is distinctive and allows to find all places with dubious error
handling. The long-term goal is to get rid of MPD_ERROR() altogether. To
facilitate the eventual removal of this macro it was added in a new header
file rather than to an existing header file.

This fixes #2995 and #3007.
This commit is contained in:
Thomas Jansen
2010-09-25 15:00:43 +02:00
parent 9af9fd1400
commit 28bcb8bdf5
27 changed files with 166 additions and 103 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/update.c
View File

@@ -28,6 +28,7 @@
#include "idle.h"
#include "stats.h"
#include "main.h"
#include "mpd_error.h"
#include <glib.h>
@@ -93,7 +94,7 @@ spawn_update_task(const char *path)
update_thr = g_thread_create(update_task, g_strdup(path), TRUE, &e);
if (update_thr == NULL)
g_error("Failed to spawn update task: %s", e->message);
MPD_ERROR("Failed to spawn update task: %s", e->message);
if (++update_task_id > update_task_id_max)
update_task_id = 1;