oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

eliminate g_error() usage

Browse Source 
Replaced all occurrences of g_error() with MPD_ERROR() located in a new header
file 'mpd_error.h'. This macro uses g_critical() to print the error message
and then exits gracefully in contrast to g_error() which would internally call
abort() to produce a core dump.

The macro name is distinctive and allows to find all places with dubious error
handling. The long-term goal is to get rid of MPD_ERROR() altogether. To
facilitate the eventual removal of this macro it was added in a new header
file rather than to an existing header file.

This fixes #2995 and #3007.
This commit is contained in:
Thomas Jansen
2010-09-25 15:00:43 +02:00
parent 9af9fd1400
commit 28bcb8bdf5
27 changed files with 166 additions and 103 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/pcm_mix.c
+5 -4
View File
@@ -22,6 +22,7 @@
#include "pcm_volume.h"
#include "pcm_utils.h"
#include "audio_format.h"
#include "mpd_error.h"
#include <glib.h>
@@ -125,8 +126,8 @@ pcm_add_vol(void *buffer1, const void *buffer2, size_t size,
break;
default:
g_error("format %s not supported by pcm_add_vol",
sample_format_to_string(format->format));
MPD_ERROR("format %s not supported by pcm_add_vol",
sample_format_to_string(format->format));
}
}
@@ -208,8 +209,8 @@ pcm_add(void *buffer1, const void *buffer2, size_t size,
break;
default:
g_error("format %s not supported by pcm_add",
sample_format_to_string(format->format));
MPD_ERROR("format %s not supported by pcm_add",
sample_format_to_string(format->format));
}
}