oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

util/UriRelative: use StringAfterPrefix() instead of memcmp()

Browse Source 
memcmp() can overrun the buffer.
This commit is contained in:
Max Kellermann 2019-09-07 23:21:01 +02:00
parent 15fbd2b4ab
commit 2574615fa3
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/util/UriRelative.cxx
View File

@ -29,6 +29,7 @@
#include "UriRelative.hxx"
#include "StringAPI.hxx"
#include "StringCompare.hxx"
#include <assert.h>
#include <string.h>
@ -42,9 +43,9 @@ uri_is_child(const char *parent, const char *child) noexcept
assert(child != nullptr);
#endif
const size_t parent_length = strlen(parent);
return memcmp(parent, child, parent_length) == 0 &&
child[parent_length] == '/';
const char *suffix = StringAfterPrefix(child, parent);
return suffix != nullptr &&
*suffix == '/';
}