oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

client: client_input_received() returns 0

Browse Source 
Since the caller chain doesn't care about the return value (except for
COMMAND_RETURN_KILL, COMMAND_RETURN_CLOSE), just return 0 if there is
nothing special.  This saves one local variable initialization, and
one access to it.

Also remove one unreachable "return 1" from client_read().
This commit is contained in:
Max Kellermann 2008-09-10 11:42:30 +02:00
parent 48191d5661
commit 1bb154098d
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/client.c
View File

@ -400,7 +400,7 @@ static int client_process_line(struct client *client)
static int client_input_received(struct client *client, int bytesRead) static int client_input_received(struct client *client, int bytesRead)
{ {
int ret = 0; int ret;
char *buf_tail = &(client->buffer[client->bufferLength - 1]); char *buf_tail = &(client->buffer[client->bufferLength - 1]);
while (bytesRead > 0) { while (bytesRead > 0) {
@ -440,7 +440,7 @@ static int client_input_received(struct client *client, int bytesRead)
} }
} }
return ret; return 0;
} }
static int client_read(struct client *client) static int client_read(struct client *client)
@ -457,8 +457,6 @@ static int client_read(struct client *client)
return COMMAND_RETURN_CLOSE; return COMMAND_RETURN_CLOSE;
} else } else
return 0; return 0;
return 1;
} }
static void client_manager_register_read_fd(fd_set * fds, int *fdmax) static void client_manager_register_read_fd(fd_set * fds, int *fdmax)