oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

command/QueueCommands: validate the "addid" position before adding the song

Browse Source 
Validate early, so we avoid the rollback if an error occurs.
This commit is contained in:
Max Kellermann
2021-10-07 21:23:51 +02:00
parent 7a6d0c2efc
commit 16cad48641
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/command/QueueCommands.cxx
View File

@@ -113,12 +113,17 @@ handle_addid(Client &client, Request args, Response &r)
const char *const uri = args.front(); const char *const uri = args.front();
auto &partition = client.GetPartition(); auto &partition = client.GetPartition();
int to = -1;
if (args.size > 1) {
const auto queue_length = partition.playlist.queue.GetLength();
to = args.ParseUnsigned(1, queue_length);
}
const SongLoader loader(client); const SongLoader loader(client);
unsigned added_id = partition.AppendURI(loader, uri); unsigned added_id = partition.AppendURI(loader, uri);
if (args.size == 2) { if (to >= 0) {
unsigned to = args.ParseUnsigned(1);
try { try {
partition.MoveId(added_id, to); partition.MoveId(added_id, to);
} catch (...) { } catch (...) {