oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

db/simple: fix implicit nullptr/bool conversion

Browse Source 
Return false on error, not nullptr.
This commit is contained in:
Max Kellermann
2014-12-26 14:31:00 +01:00
parent 95f84afd33
commit 163597ef69
3 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/db/plugins/simple/SimpleDatabasePlugin.cxx
View File

@@ -448,13 +448,13 @@ SimpleDatabase::Mount(const char *uri, Database *db, Error &error)
if (r.uri == nullptr) {
error.Format(db_domain, DB_CONFLICT,
"Already exists: %s", uri);
return nullptr;
return false;
}
if (strchr(r.uri, '/') != nullptr) {
error.Format(db_domain, DB_NOT_FOUND,
"Parent not found: %s", uri);
return nullptr;
return false;
}
Directory *mnt = r.directory->CreateChild(r.uri);
@@ -481,7 +481,7 @@ SimpleDatabase::Mount(const char *local_uri, const char *storage_uri,
if (cache_path.IsNull()) {
error.Format(db_domain, DB_NOT_FOUND,
"No 'cache_directory' configured");
return nullptr;
return false;
}
std::string name(storage_uri);