oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

protocol/ArgParser: fix range check

Browse Source 
The old check

 unsigned(value) > std::numeric_limits<unsigned>::max()

.. cannot ever fail.
This commit is contained in:
Max Kellermann 2016-03-06 23:41:08 +01:00
parent b24cbc68ba
commit 1532ffe215
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/protocol/ArgParser.cxx
View File

@ -92,7 +92,7 @@ check_range(Client &client, unsigned *value_r1, unsigned *value_r2,
return false; return false;
} }
if (unsigned(value) > std::numeric_limits<unsigned>::max()) { if (value > std::numeric_limits<int>::max()) {
command_error(client, ACK_ERROR_ARG, command_error(client, ACK_ERROR_ARG,
"Number too large: %s", s); "Number too large: %s", s);
return false; return false;
@ -117,7 +117,7 @@ check_range(Client &client, unsigned *value_r1, unsigned *value_r2,
return false; return false;
} }
if (unsigned(value) > std::numeric_limits<unsigned>::max()) { if (value > std::numeric_limits<int>::max()) {
command_error(client, ACK_ERROR_ARG, command_error(client, ACK_ERROR_ARG,
"Number too large: %s", s); "Number too large: %s", s);
return false; return false;