oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

filter/volume: remove from filter_plugins[]

Browse Source 
Thsi filter doesn't make sense as manually configured plugin, because
nobody ever calls volume_filter_set() on it, making it a no-op.
This commit is contained in:
Max Kellermann 2017-12-27 11:34:43 +01:00
parent b335ac4156
commit 0e3ff12dd3
3 changed files with 0 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/filter/FilterRegistry.cxx
View File

@ -27,7 +27,6 @@ static const FilterPlugin *const filter_plugins[] = {
&null_filter_plugin, &null_filter_plugin,
&route_filter_plugin, &route_filter_plugin,
&normalize_filter_plugin, &normalize_filter_plugin,
&volume_filter_plugin,
nullptr, nullptr,
}; };

1
src/filter/FilterRegistry.hxx
View File

@ -33,7 +33,6 @@ struct FilterPlugin;
extern const FilterPlugin null_filter_plugin; extern const FilterPlugin null_filter_plugin;
extern const FilterPlugin route_filter_plugin; extern const FilterPlugin route_filter_plugin;
extern const FilterPlugin normalize_filter_plugin; extern const FilterPlugin normalize_filter_plugin;
extern const FilterPlugin volume_filter_plugin;
gcc_pure gcc_pure
const FilterPlugin * const FilterPlugin *

13
src/filter/plugins/VolumeFilterPlugin.cxx
View File

@ -19,9 +19,7 @@
#include "config.h" #include "config.h"
#include "VolumeFilterPlugin.hxx" #include "VolumeFilterPlugin.hxx"
#include "filter/FilterPlugin.hxx"
#include "filter/FilterInternal.hxx" #include "filter/FilterInternal.hxx"
#include "filter/FilterRegistry.hxx"
#include "pcm/Volume.hxx" #include "pcm/Volume.hxx"
#include "AudioFormat.hxx" #include "AudioFormat.hxx"
#include "util/ConstBuffer.hxx" #include "util/ConstBuffer.hxx"
@ -55,12 +53,6 @@ public:
Filter *Open(AudioFormat &af) override; Filter *Open(AudioFormat &af) override;
}; };
static PreparedFilter *
volume_filter_init(gcc_unused const ConfigBlock &block)
{
return new PreparedVolumeFilter();
}
Filter * Filter *
PreparedVolumeFilter::Open(AudioFormat &audio_format) PreparedVolumeFilter::Open(AudioFormat &audio_format)
{ {
@ -73,11 +65,6 @@ VolumeFilter::FilterPCM(ConstBuffer<void> src)
return pv.Apply(src); return pv.Apply(src);
} }
const FilterPlugin volume_filter_plugin = {
"volume",
volume_filter_init,
};
PreparedFilter * PreparedFilter *
volume_filter_prepare() noexcept volume_filter_prepare() noexcept
{ {