oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

encoder/Plugin: migrate from class Error to C++ exceptions

Browse Source
This commit is contained in:
Max Kellermann
2016-10-28 21:29:01 +02:00
parent aead221184
commit 0c343cb1c3
15 changed files with 145 additions and 257 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
src/encoder/plugins/FlacEncoderPlugin.cxx
View File

@@ -89,10 +89,10 @@ private:
};
class PreparedFlacEncoder final : public PreparedEncoder {
unsigned compression;
const unsigned compression;
public:
bool Configure(const ConfigBlock &block, Error &error);
PreparedFlacEncoder(const ConfigBlock &block);
/* virtual methods from class PreparedEncoder */
Encoder *Open(AudioFormat &audio_format, Error &) override;
@@ -104,26 +104,15 @@ public:
static constexpr Domain flac_encoder_domain("vorbis_encoder");
bool
PreparedFlacEncoder::Configure(const ConfigBlock &block, Error &)
PreparedFlacEncoder::PreparedFlacEncoder(const ConfigBlock &block)
:compression(block.GetBlockValue("compression", 5u))
{
compression = block.GetBlockValue("compression", 5u);
return true;
}
static PreparedEncoder *
flac_encoder_init(const ConfigBlock &block, Error &error)
flac_encoder_init(const ConfigBlock &block)
{
auto *encoder = new PreparedFlacEncoder();
/* load configuration from "block" */
if (!encoder->Configure(block, error)) {
/* configuration has failed, roll back and return error */
delete encoder;
return nullptr;
}
return encoder;
return new PreparedFlacEncoder(block);
}
static bool