storage: add abstract interface

Prepare for the plugin interface.
This commit is contained in:
Max Kellermann
2014-02-05 17:03:43 +01:00
parent 4c995eb498
commit 0ba1b73395
11 changed files with 146 additions and 60 deletions

View File

@@ -61,7 +61,7 @@ class UpdateService final : DeferredMonitor {
public:
UpdateService(EventLoop &_loop, SimpleDatabase &_db,
LocalStorage &_storage,
Storage &_storage,
DatabaseListener &_listener);
/**

View File

@@ -151,7 +151,7 @@ UpdateService::RunDeferred()
}
UpdateService::UpdateService(EventLoop &_loop, SimpleDatabase &_db,
LocalStorage &_storage,
Storage &_storage,
DatabaseListener &_listener)
:DeferredMonitor(_loop), db(_db), listener(_listener),
progress(UPDATE_PROGRESS_IDLE),

View File

@@ -22,7 +22,7 @@
#include "UpdateDomain.hxx"
#include "db/Directory.hxx"
#include "storage/FileInfo.hxx"
#include "storage/LocalStorage.hxx"
#include "storage/StorageInterface.hxx"
#include "fs/Traits.hxx"
#include "fs/FileSystem.hxx"
#include "util/Error.hxx"
@@ -32,7 +32,7 @@
#include <unistd.h>
bool
GetInfo(LocalStorage &storage, const char *uri_utf8, FileInfo &info)
GetInfo(Storage &storage, const char *uri_utf8, FileInfo &info)
{
Error error;
bool success = storage.GetInfo(uri_utf8, true, info, error);
@@ -42,7 +42,7 @@ GetInfo(LocalStorage &storage, const char *uri_utf8, FileInfo &info)
}
bool
GetInfo(LocalDirectoryReader &reader, FileInfo &info)
GetInfo(StorageDirectoryReader &reader, FileInfo &info)
{
Error error;
bool success = reader.GetInfo(true, info, error);
@@ -52,7 +52,7 @@ GetInfo(LocalDirectoryReader &reader, FileInfo &info)
}
bool
DirectoryExists(LocalStorage &storage, const Directory &directory)
DirectoryExists(Storage &storage, const Directory &directory)
{
FileInfo info;
if (!storage.GetInfo(directory.GetPath(), true, info, IgnoreError()))
@@ -65,7 +65,7 @@ DirectoryExists(LocalStorage &storage, const Directory &directory)
}
static bool
GetDirectoryChildInfo(LocalStorage &storage, const Directory &directory,
GetDirectoryChildInfo(Storage &storage, const Directory &directory,
const char *name_utf8, FileInfo &info, Error &error)
{
const auto uri_utf8 = PathTraitsUTF8::Build(directory.GetPath(),
@@ -74,7 +74,7 @@ GetDirectoryChildInfo(LocalStorage &storage, const Directory &directory,
}
bool
directory_child_is_regular(LocalStorage &storage, const Directory &directory,
directory_child_is_regular(Storage &storage, const Directory &directory,
const char *name_utf8)
{
FileInfo info;
@@ -84,7 +84,7 @@ directory_child_is_regular(LocalStorage &storage, const Directory &directory,
}
bool
directory_child_access(LocalStorage &storage, const Directory &directory,
directory_child_access(Storage &storage, const Directory &directory,
const char *name, int mode)
{
#ifdef WIN32

View File

@@ -25,30 +25,30 @@
struct Directory;
struct FileInfo;
class LocalStorage;
class LocalDirectoryReader;
class Storage;
class StorageDirectoryReader;
/**
* Wrapper for LocalStorage::GetInfo() that logs errors instead of
* Wrapper for Storage::GetInfo() that logs errors instead of
* returning them.
*/
bool
GetInfo(LocalStorage &storage, const char *uri_utf8, FileInfo &info);
GetInfo(Storage &storage, const char *uri_utf8, FileInfo &info);
/**
* Wrapper for LocalDirectoryReader::GetInfo() that logs errors
* instead of returning them.
*/
bool
GetInfo(LocalDirectoryReader &reader, FileInfo &info);
GetInfo(StorageDirectoryReader &reader, FileInfo &info);
gcc_pure
bool
DirectoryExists(LocalStorage &storage, const Directory &directory);
DirectoryExists(Storage &storage, const Directory &directory);
gcc_pure
bool
directory_child_is_regular(LocalStorage &storage, const Directory &directory,
directory_child_is_regular(Storage &storage, const Directory &directory,
const char *name_utf8);
/**
@@ -56,7 +56,7 @@ directory_child_is_regular(LocalStorage &storage, const Directory &directory,
*/
gcc_pure
bool
directory_child_access(LocalStorage &storage, const Directory &directory,
directory_child_access(Storage &storage, const Directory &directory,
const char *name, int mode);
#endif

View File

@@ -27,7 +27,7 @@
#include "db/Song.hxx"
#include "db/PlaylistVector.hxx"
#include "db/Uri.hxx"
#include "storage/LocalStorage.hxx"
#include "storage/StorageInterface.hxx"
#include "playlist/PlaylistRegistry.hxx"
#include "Mapper.hxx"
#include "ExcludeList.hxx"
@@ -49,7 +49,7 @@
#include <errno.h>
UpdateWalk::UpdateWalk(EventLoop &_loop, DatabaseListener &_listener,
LocalStorage &_storage)
Storage &_storage)
:storage(_storage),
editor(_loop, _listener)
{
@@ -140,7 +140,7 @@ UpdateWalk::PurgeDeletedFromDirectory(Directory &directory)
#ifndef WIN32
static bool
update_directory_stat(LocalStorage &storage, Directory &directory)
update_directory_stat(Storage &storage, Directory &directory)
{
FileInfo info;
if (!GetInfo(storage, directory.GetPath(), info))
@@ -152,7 +152,7 @@ update_directory_stat(LocalStorage &storage, Directory &directory)
#endif
static int
find_inode_ancestor(LocalStorage &storage, Directory *parent,
find_inode_ancestor(Storage &storage, Directory *parent,
unsigned inode, unsigned device)
{
#ifndef WIN32
@@ -320,7 +320,7 @@ UpdateWalk::UpdateDirectory(Directory &directory, const FileInfo &info)
directory_set_stat(directory, info);
Error error;
LocalDirectoryReader *const reader =
StorageDirectoryReader *const reader =
storage.OpenDirectory(directory.GetPath(), error);
if (reader == nullptr) {
LogError(error);

View File

@@ -29,7 +29,7 @@ struct stat;
struct FileInfo;
struct Directory;
struct archive_plugin;
class LocalStorage;
class Storage;
class ExcludeList;
class UpdateWalk final {
@@ -48,13 +48,13 @@ class UpdateWalk final {
bool walk_discard;
bool modified;
LocalStorage &storage;
Storage &storage;
DatabaseEditor editor;
public:
UpdateWalk(EventLoop &_loop, DatabaseListener &_listener,
LocalStorage &_storage);
Storage &_storage);
/**
* Returns true if the database was modified.