oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

prevent use after move

Browse Source 
These should be equivalent anyway.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
This commit is contained in:
Rosen Penev 2021-08-26 13:31:53 -07:00
parent 9ca64d5fb3
commit 0b774df375
3 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/db/plugins/upnp/Directory.cxx
View File

@ -192,7 +192,7 @@ protected:
if (tag_type == TAG_TITLE) if (tag_type == TAG_TITLE)
object.name = TitleToPathSegment(std::move(value)); object.name = TitleToPathSegment(std::move(value));
value.clear(); value = {};
tag_type = TAG_NUM_OF_ITEM_TYPES; tag_type = TAG_NUM_OF_ITEM_TYPES;
return; return;
} }

2
src/decoder/Control.cxx
View File

@ -170,5 +170,5 @@ void
DecoderControl::CycleMixRamp() noexcept DecoderControl::CycleMixRamp() noexcept
{ {
previous_mix_ramp = std::move(mix_ramp); previous_mix_ramp = std::move(mix_ramp);
mix_ramp.Clear(); mix_ramp = {};
} }

6
src/playlist/cue/CueParser.cxx
View File

@ -171,7 +171,6 @@ CueParser::Commit() noexcept
finished = std::move(previous); finished = std::move(previous);
previous = std::move(current); previous = std::move(current);
current.reset();
} }
void void
@ -302,10 +301,7 @@ CueParser::Get() noexcept
assert(current == nullptr); assert(current == nullptr);
finished = std::move(previous); finished = std::move(previous);
previous.reset();
} }
auto result = std::move(finished); return std::move(finished);
finished.reset();
return result;
} }