oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

client/Client: pass std::string_view to Write()

Browse Source 
Almost all callers have string literal, and the length is known at
compile time.
This commit is contained in:
Max Kellermann 2021-10-22 11:53:50 +02:00
parent 0c4bf12bfd
commit 0a48146efc
2 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/client/Client.hxx
View File

@ -150,7 +150,9 @@ public:
/** /**
* Write a null-terminated string. * Write a null-terminated string.
*/ */
bool Write(const char *data) noexcept; bool Write(std::string_view s) noexcept {
return Write(s.data(), s.size());
}
/** /**
* returns the uid of the client process, or a negative value * returns the uid of the client process, or a negative value

6
src/client/Write.cxx
View File

@ -27,9 +27,3 @@ Client::Write(const void *data, size_t length) noexcept
/* if the client is going to be closed, do nothing */ /* if the client is going to be closed, do nothing */
return !IsExpired() && FullyBufferedSocket::Write(data, length); return !IsExpired() && FullyBufferedSocket::Write(data, length);
} }
bool
Client::Write(const char *data) noexcept
{
return Write(data, strlen(data));
}