oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

output/roar: remove

Browse Source 
Bugs in libroar which broke the MPD build have been annoying me for
quite some time, and the newest bug has now hit my main build machine:

 https://github.com/MusicPlayerDaemon/MPD/issues/377

Problem is the usage of the typedef `_IO_off64_t` in libroar's
`vio_stdio.h`:

 int roar_vio_to_stdio_lseek (void *__cookie, _IO_off64_t *__pos, int __w);

This `_IO_off64_t` is an internal implementation detail of glibc and
was removed in version 2.28.  Nobody must ever use it.  Why the ****
did the RoarAudio developers use it?  Not using internal typedefs
isn't exactly rocket science.

This annoys me enough to finally remove the plugin.  Anyway, I've
never heard of anybody using RoarAudio, so my best guess is that
nobody will notice.
This commit is contained in:
Max Kellermann
2018-10-31 15:03:28 +01:00
parent 9fc00a817b
commit 06ca08ce55
13 changed files with 2 additions and 485 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
doc/user.rst
View File

@@ -72,7 +72,7 @@ For example, the following installs a fairly complete list of build dependencies
libzzip-dev \
libcurl4-gnutls-dev libyajl-dev libexpat-dev \
libasound2-dev libao-dev libjack-jackd2-dev libopenal-dev \
libpulse-dev libroar-dev libshout3-dev \
libpulse-dev libshout3-dev \
libsndio-dev \
libmpdclient-dev \
libnfs-dev libsmbclient-dev \