[cppcheck] convert several functions to use std::all_of

std::all_of becomes constexpr in C++20. I'm not sure it results in better
performance.

Found with useStlAlgorithm

Signed-off-by: Rosen Penev <rosenp@gmail.com>
This commit is contained in:
Rosen Penev
2020-03-26 21:29:30 -07:00
parent 3540cf26b1
commit 015cbff93d
7 changed files with 12 additions and 36 deletions

View File

@@ -258,11 +258,8 @@ MultipleOutputs::Open(const AudioFormat audio_format)
bool
MultipleOutputs::IsChunkConsumed(const MusicChunk *chunk) const noexcept
{
for (const auto &ao : outputs)
if (!ao->LockIsChunkConsumed(*chunk))
return false;
return true;
return std::all_of(outputs.begin(), outputs.end(), [chunk](const auto &ao) {
return ao->LockIsChunkConsumed(*chunk); });
}
unsigned

View File

@@ -28,6 +28,7 @@
#include "Chrono.hxx"
#include "util/Compiler.h"
#include <algorithm>
#include <cassert>
#include <memory>
#include <vector>
@@ -106,11 +107,7 @@ public:
*/
gcc_pure
bool IsDummy() const noexcept {
for (const auto &i : outputs)
if (!i->IsDummy())
return false;
return true;
return std::all_of(outputs.begin(), outputs.end(), [](const auto &i) { return i->IsDummy(); });
}
/**