Felix Albrigtsen felixalb
  • Joined on 2023-06-04
felixalb approved Drift/pvv-nixos-config#70 2024-08-27 17:37:08 +02:00
bekkalokk/gitea/import-users: refactor + add members to groups

Some comments about separating "add" and "update", as they don't have to relate to each other at all, but it's not a blocker. This is after all Nitea, you can merge if you disagree.

felixalb commented on pull request Drift/pvv-nixos-config#70 2024-08-27 17:37:08 +02:00
bekkalokk/gitea/import-users: refactor + add members to groups

Here, you are both explicitly allowing very long lines, and strictly wrapping the text. Maybe collapse this type of comment into single lines?

felixalb commented on pull request Drift/pvv-nixos-config#70 2024-08-27 17:37:08 +02:00
bekkalokk/gitea/import-users: refactor + add members to groups

This "patch existing users" section should probably be it's own function, and be explained to show what it is / should be doing.

felixalb commented on pull request Drift/pvv-nixos-config#70 2024-08-27 17:37:08 +02:00
bekkalokk/gitea/import-users: refactor + add members to groups

The splitting into "add" or "patch" should probably also be done here, rather than in one large function, as they are quite different.

felixalb commented on pull request Drift/pvv-nixos-config#70 2024-08-27 17:37:08 +02:00
bekkalokk/gitea/import-users: refactor + add members to groups

This makes it explicitly impossible to leave either of those teams for good, is that intended? I suggest moving this into the "add new user" function, and not the "update existing user" section.

felixalb commented on pull request Drift/pvv-nixos-config#70 2024-08-27 17:30:52 +02:00
bekkalokk/gitea/import-users: refactor + add members to groups

Should the required token permissions be listed in the source code somewhere?

felixalb commented on issue Drift/issues#146 2024-08-27 17:23:58 +02:00
Fix openstack networking

Heh, there are several problems here, I fix

felixalb approved Drift/pvv-nixos-config#65 2024-08-26 20:34:39 +02:00
Set up web hosting for gitea projects

Let's Get This Militarized 🚀

felixalb commented on issue Drift/issues#144 2024-08-26 20:24:29 +02:00
Aggregate "magic directories" under ~/public (or something equivalent)

At the same time, I would maybe like to add some placeholder directories and README.txt into /etc/skel, to prepare this for new users.

felixalb commented on issue Drift/issues#144 2024-08-26 20:23:48 +02:00
Aggregate "magic directories" under ~/public (or something equivalent)

~/web-docs has been here forever, and I expect people to have these files linked all over the place, scripts with hard-coded paths, scripts that automatically put things in ~/web-docs,…

felixalb approved Drift/pvv-nixos-config#67 2024-08-26 20:21:46 +02:00
some systemd hardening

I would like a few internet-exposed services, such as postgresql, as well, but at least noone can rotate our logs with malice anymore.

felixalb commented on issue Drift/issues#124 2024-08-26 20:20:11 +02:00
Fix salt dependencies, such as jinja2 (Isvegg++)

Just for the record, the failing packages are the packages from the [upstream apt repositories](https://docs.saltproject.io/salt/install-guide/en/latest/topics/install-by-operating-system/ubuntu.…

felixalb commented on pull request Drift/pvv-nixos-config#65 2024-08-26 18:45:13 +02:00
Set up web hosting for gitea projects

Ah, yes they're 0600, oops. Well, why does nginx have to be in the gitea-web group? I believe gitea-web:nginx and no extra groups is better if that works?

felixalb commented on pull request Drift/pvv-nixos-config#65 2024-08-26 18:38:10 +02:00
Set up web hosting for gitea projects

Do we need both users.users.nginx.extraGroups = [ "gitea-web" ]; when we have /chown -R gitea-web:nginx "$1"? If we remove nginx from the gitea-web-group, other things running under nginx

felixalb commented on issue Drift/issues#79 2024-08-26 10:17:56 +02:00
Gjennopprette gamle nettsteder som knakelibrak hostet

Principal er også litt strømlaus og mangler internett for tida da den står i serverskapet på kjøkkenet, men vi kunne eventuelt pirka ut disken og tatt en kikk.

Jeg ville helst ikke tatt…

felixalb commented on pull request Projects/nettsiden#73 2024-08-25 18:03:01 +02:00
composer.lock: bump

The simplesamlphp-diff is quite large, we should probably test that we can still auth with this update? I have been having…

felixalb commented on pull request Projects/nettsiden#75 2024-08-25 16:42:34 +02:00
WIP: readd-webmail, fixes #70

I marked it WIP as I did a few things on the files I touched;

  • Reindented to a reasonable indentation style
  • Moved pictures/PNGs out of the /css directory

However, I did not explain…

felixalb deleted branch dependabot/composer/twig/twig-2.15.3 from Projects/nettsiden 2024-08-25 16:38:50 +02:00