Projects/nettsiden
Projects
/
nettsiden
8
2
Fork 0
Code Issues 15 Pull Requests 2 Activity

Uploaded door sensor #15

Merged
felixalbrigtsen merged 2 commits from doorsensor into master 2021-09-08 22:23:38 +02:00
Conversation 0 Commits 2 Files Changed 8 +170 -132
felixalbrigtsen commented 2021-09-04 17:01:39 +02:00 (Migrated from github.com)
Copy Link
No description provided.
SondreElg (Migrated from github.com) reviewed 2021-09-04 17:01:39 +02:00
pbsds (Migrated from github.com) requested changes 2021-09-08 18:58:44 +02:00
pbsds (Migrated from github.com) left a comment
Copy Link

Good work, men oppdater gjerne dist/sql_config_example.php med ett eksempel bearer token.

Good work, men oppdater gjerne [`dist/sql_config_example.php`](https://github.com/Programvareverkstedet/nettsiden/blob/master/dist/sql_config_example.php) med ett eksempel bearer token.
src/pvv/side/door.php
pbsds (Migrated from github.com) commented 2021-09-08 18:36:53 +02:00
Copy Link

Why no cast to int and bool here?

Why no cast to int and bool here?
src/pvv/side/door.php
@ -0,0 +54,4 @@
];
}
private function removeOld() {
pbsds (Migrated from github.com) commented 2021-09-08 18:44:51 +02:00
Copy Link

nice, relational databases don't scale well with a lot of timeseries data

how often is it run?

nice, relational databases don't scale well with a lot of timeseries data how often is it run?
www/door/index.php
@ -14,0 +15,4 @@
echo '{"status": "error", "message": "Invalid authentication key"}';
die();
}
} else {
pbsds (Migrated from github.com) commented 2021-09-08 18:46:05 +02:00
Copy Link

i assume this will work in lighttpd

i assume this will work in lighttpd
www/door/index.php
@ -14,0 +17,4 @@
}
} else {
echo '{"status": "error", "message": "Invalid authentication method"}';
die();
pbsds (Migrated from github.com) commented 2021-09-08 18:46:54 +02:00
Copy Link

should include the space after "Bearer"

should include the space after "Bearer"
www/door/index.php
@ -14,1 +18,4 @@
} else {
echo '{"status": "error", "message": "Invalid authentication method"}';
die();
}
pbsds (Migrated from github.com) commented 2021-09-08 18:51:07 +02:00
Copy Link

Where is doorSensorSecret set?

Where is `doorSensorSecret` set?
www/index.php
pbsds (Migrated from github.com) commented 2021-09-08 18:56:36 +02:00
Copy Link

This could be made to be only visible when more than x minutes old.
If within reason, show it only on mouseover on desktop.

This could be made to be only visible when more than x minutes old. If within reason, show it only on [mouseover](https://www.w3schools.com/tags/att_global_title.asp#:~:text=HTML%20title%20Attribute&text=The%20title%20attribute%20specifies%20extra,it%20is%20not%20necessarily%20useful) on desktop.
pbsds (Migrated from github.com) requested changes 2021-09-08 19:00:42 +02:00
src/pvv/side/door.php
@ -0,0 +43,4 @@
return $doorEvents;
}
public function getCurrent() {
pbsds (Migrated from github.com) commented 2021-09-08 19:00:19 +02:00
Copy Link

What happens here if the table is empty?

What happens here if the table is empty?
felixalbrigtsen (Migrated from github.com) reviewed 2021-09-08 19:19:50 +02:00
src/pvv/side/door.php
@ -0,0 +54,4 @@
];
}
private function removeOld() {
felixalbrigtsen (Migrated from github.com) commented 2021-09-08 19:19:50 +02:00
Copy Link

The Raspberry Pi(Probaly ESP8266 later) posts the door state once every 15 minutes and immediately if the state changes.
4 times an hour * 24 * 7 = 672, so the database currently stores approximately 700 elements. Can be greatly reduced by only storing actual changes...

The Raspberry Pi(Probaly ESP8266 later) posts the door state once every 15 minutes and immediately if the state changes. 4 times an hour * 24 * 7 = 672, so the database currently stores approximately 700 elements. Can be greatly reduced by only storing actual changes...
felixalbrigtsen (Migrated from github.com) reviewed 2021-09-08 19:27:08 +02:00
www/door/index.php
@ -14,1 +18,4 @@
} else {
echo '{"status": "error", "message": "Invalid authentication method"}';
die();
}
felixalbrigtsen (Migrated from github.com) commented 2021-09-08 19:27:08 +02:00
Copy Link

In sql_config.php, appended a dummy in sql_config_example.php

In sql_config.php, appended a dummy in sql_config_example.php
pbsds (Migrated from github.com) reviewed 2021-09-08 20:26:06 +02:00
src/pvv/side/door.php
@ -0,0 +54,4 @@
];
}
private function removeOld() {
pbsds (Migrated from github.com) commented 2021-09-08 20:26:06 +02:00
Copy Link

ah, it's called in createEvent

ah, it's called in createEvent
felixalbrigtsen (Migrated from github.com) reviewed 2021-09-08 20:26:53 +02:00
src/pvv/side/door.php
@ -0,0 +43,4 @@
return $doorEvents;
}
public function getCurrent() {
felixalbrigtsen (Migrated from github.com) commented 2021-09-08 20:26:53 +02:00
Copy Link

Tested and checked, door.php exhbits the preferred behaviour even with an empty table; getCurrent() returns time=0 and open=false, and getEntriesAfter returns entries=[].

Tested and checked, door.php exhbits the preferred behaviour even with an empty table; getCurrent() returns time=0 and open=false, and getEntriesAfter returns entries=[].
pbsds (Migrated from github.com) reviewed 2021-09-08 20:29:30 +02:00
src/pvv/side/door.php
@ -0,0 +43,4 @@
return $doorEvents;
}
public function getCurrent() {
pbsds (Migrated from github.com) commented 2021-09-08 20:29:30 +02:00
Copy Link

So i assume $row is an empty map, and accessing it returns null, which gets cast into 0 and False?

So i assume $row is an empty map, and accessing it returns null, which gets cast into 0 and False?
felixalbrigtsen (Migrated from github.com) reviewed 2021-09-08 21:27:11 +02:00
src/pvv/side/door.php
@ -0,0 +43,4 @@
return $doorEvents;
}
public function getCurrent() {
felixalbrigtsen (Migrated from github.com) commented 2021-09-08 21:27:11 +02:00
Copy Link

Correct, I check all types coming in, and extensively cast everything to the correct type before JSON encoding. Only ints(here cast to 0) and bools(here cast to false) can be returned as far as I can see.

Correct, I check all types coming in, and extensively cast everything to the correct type before JSON encoding. Only ints(here cast to 0) and bools(here cast to false) can be returned as far as I can see.
Sign in to join this conversation.
Reviewers
No reviewers
SondreElg
pbsds
Labels
Clear labels
  
art

The issue needs someone to be creative

  
big

No, not bug, **big** - this is gonna take a while

  
blocked

This issue/PR depends on one or more other issues/PRs

  
bug

Something is not working, and it's not the shield hero

  
crash report

Report an oopsie

  
disputed

kranglefanter

  
documentation

Documentation changes required

  
duplicate

This issue or pull request already exists

  
feature request

New feature

  
good first issue

Get your hands dirty with a new project here

  
packaging

Relates to distribution of the software

  
question

More information is needed

  
security

Skommel

  
wontfix

This won't be fixed

No Label
art
big
blocked
bug
crash report
disputed
documentation
duplicate
feature request
good first issue
packaging
question
security
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Projects/nettsiden#15
No description provided.
Delete Branch "doorsensor"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?