Misc 5 #67

Merged
oysteikt merged 2 commits from misc into main 2024-08-19 00:50:14 +02:00
3 changed files with 27 additions and 2 deletions

View File

@ -6,7 +6,8 @@ use futures_util::{SinkExt, StreamExt};
use crate::core::protocol::{ use crate::core::protocol::{
print_create_users_output_status, print_drop_users_output_status, print_create_users_output_status, print_drop_users_output_status,
print_lock_users_output_status, print_set_password_output_status, print_lock_users_output_status, print_set_password_output_status,
print_unlock_users_output_status, ClientToServerMessageStream, Request, Response, print_unlock_users_output_status, ClientToServerMessageStream, ListUsersError, Request,
Response,
}; };
use super::common::erroneous_server_response; use super::common::erroneous_server_response;
@ -207,6 +208,28 @@ async fn passwd_user(
args: UserPasswdArgs, args: UserPasswdArgs,
mut server_connection: ClientToServerMessageStream, mut server_connection: ClientToServerMessageStream,
) -> anyhow::Result<()> { ) -> anyhow::Result<()> {
// TODO: create a "user" exists check" command
let message = Request::ListUsers(Some(vec![args.username.clone()]));
if let Err(err) = server_connection.send(message).await {
server_connection.close().await.ok();
anyhow::bail!(err);
}
let response = match server_connection.next().await {
Some(Ok(Response::ListUsers(users))) => users,
response => return erroneous_server_response(response),
};
match response
.get(&args.username)
.unwrap_or(&Err(ListUsersError::UserDoesNotExist))
{
Ok(_) => {}
Err(err) => {
server_connection.send(Request::Exit).await?;
server_connection.close().await.ok();
anyhow::bail!("{}", err.to_error_message(&args.username));
}
}
let password = if let Some(password_file) = args.password_file { let password = if let Some(password_file) = args.password_file {
std::fs::read_to_string(password_file) std::fs::read_to_string(password_file)
.context("Failed to read password file")? .context("Failed to read password file")?

View File

@ -76,6 +76,7 @@ impl OwnerValidationError {
indoc! {r#" indoc! {r#"
Invalid {} name prefix: '{}' does not match your username or any of your groups. Invalid {} name prefix: '{}' does not match your username or any of your groups.
Are you sure you are allowed to create {} names with this prefix? Are you sure you are allowed to create {} names with this prefix?
The format should be: <prefix>_<{} name>
Allowed prefixes: Allowed prefixes:
- {} - {}
@ -84,6 +85,7 @@ impl OwnerValidationError {
db_or_user.lowercased(), db_or_user.lowercased(),
name, name,
db_or_user.lowercased(), db_or_user.lowercased(),
db_or_user.lowercased(),
user.as_ref() user.as_ref()
.map(|u| u.username.clone()) .map(|u| u.username.clone())
.unwrap_or("???".to_string()), .unwrap_or("???".to_string()),

View File

@ -45,7 +45,7 @@ pub fn validate_ownership_by_prefixes(
if prefixes if prefixes
.iter() .iter()
.filter(|p| name.starts_with(*p)) .filter(|p| name.starts_with(&(p.to_string() + "_")))
.collect::<Vec<_>>() .collect::<Vec<_>>()
.is_empty() .is_empty()
{ {