Add warning comments for functions running as SUID/SGID

src/cli/mysql_admutils_compatibility/mysql_dbadm.rs

@@ -143,6 +143,7 @@ pub struct EditPermArgs {
     pub database: MySQLDatabase,
 }
 
+/// **WARNING:** This function may be run with elevated privileges.
 pub fn main() -> anyhow::Result<()> {
     let args: Args = Args::parse();
 

src/cli/mysql_admutils_compatibility/mysql_useradm.rs

@@ -108,6 +108,7 @@ pub struct ShowArgs {
     name: Vec<MySQLUser>,
 }
 
+/// **WARNING:** This function may be run with elevated privileges.
 pub fn main() -> anyhow::Result<()> {
     let args: Args = Args::parse();
 

src/core/bootstrap.rs

@@ -59,6 +59,8 @@ fn will_connect_to_external_server(
 /// Note that this function is also responsible for setting up logging,
 /// because in the case of an internal server, we need to drop privileges
 /// before we can initialize logging.
+///
+/// **WARNING:** This function may be run with elevated privileges.
 pub fn bootstrap_server_connection_and_drop_privileges(
     server_socket_path: Option<PathBuf>,
     config: Option<PathBuf>,

src/main.rs

@@ -106,9 +106,7 @@ enum ToplevelCommands {
     MysqlUseradm,
 }
 
-// TODO: tag all functions that are run with elevated privileges with
+/// **WARNING:** This function may be run with elevated privileges.
-//       comments emphasizing the need for caution.
-
 fn main() -> anyhow::Result<()> {
     #[cfg(feature = "mysql-admutils-compatibility")]
     if handle_mysql_admutils_command()?.is_some() {
@@ -136,6 +134,7 @@ fn main() -> anyhow::Result<()> {
     Ok(())
 }
 
+/// **WARNING:** This function may be run with elevated privileges.
 fn handle_mysql_admutils_command() -> anyhow::Result<Option<()>> {
     let argv0 = std::env::args().next().and_then(|s| {
         PathBuf::from(s)
@@ -150,6 +149,7 @@ fn handle_mysql_admutils_command() -> anyhow::Result<Option<()>> {
     }
 }
 
+/// **WARNING:** This function may be run with elevated privileges.
 fn handle_server_command(args: &Args) -> anyhow::Result<Option<()>> {
     match args.command {
         Command::Server(ref command) => {
@@ -169,6 +169,7 @@ fn handle_server_command(args: &Args) -> anyhow::Result<Option<()>> {
     }
 }
 
+/// **WARNING:** This function may be run with elevated privileges.
 fn handle_generate_completions_command(args: &Args) -> anyhow::Result<Option<()>> {
     match args.command {
         Command::GenerateCompletions(ref completion_args) => {
@@ -199,6 +200,7 @@ fn handle_generate_completions_command(args: &Args) -> anyhow::Result<Option<()>
     }
 }
 
+/// Start a long-lived server using Tokio.
 fn tokio_start_server(
     server_socket_path: Option<PathBuf>,
     config_path: Option<PathBuf>,
@@ -214,6 +216,9 @@ fn tokio_start_server(
         })
 }
 
+/// Run the given commmand (from the client side) using Tokio.
+///
+/// **WARNING:** This function may be run with elevated privileges.
 fn tokio_run_command(command: Command, server_connection: StdUnixStream) -> anyhow::Result<()> {
     tokio::runtime::Builder::new_current_thread()
         .enable_all()