Remove a few TODOs, either solved or converted to issue
This commit is contained in:
parent
94e0e5d6c7
commit
8fdfe457ac
|
@ -356,13 +356,6 @@ pub async fn edit_database_privileges(
|
||||||
response => return erroneous_server_response(response),
|
response => return erroneous_server_response(response),
|
||||||
};
|
};
|
||||||
|
|
||||||
// TODO: The data from args should not be absolute.
|
|
||||||
// In the current implementation, the user would need to
|
|
||||||
// provide all privileges for all users on all databases.
|
|
||||||
// The intended effect is to modify the privileges which have
|
|
||||||
// matching users and databases, as well as add any
|
|
||||||
// new db-user pairs. This makes it impossible to remove
|
|
||||||
// privileges, but that is an issue for another day.
|
|
||||||
let privileges_to_change = if !args.privs.is_empty() {
|
let privileges_to_change = if !args.privs.is_empty() {
|
||||||
parse_privilege_tables_from_args(&args)?
|
parse_privilege_tables_from_args(&args)?
|
||||||
} else {
|
} else {
|
||||||
|
@ -398,7 +391,6 @@ pub async fn edit_database_privileges(
|
||||||
response => return erroneous_server_response(response),
|
response => return erroneous_server_response(response),
|
||||||
};
|
};
|
||||||
|
|
||||||
// TODO: allow user to return and correct their mistake
|
|
||||||
print_modify_database_privileges_output_status(&result);
|
print_modify_database_privileges_output_status(&result);
|
||||||
|
|
||||||
server_connection.send(Request::Exit).await?;
|
server_connection.send(Request::Exit).await?;
|
||||||
|
|
|
@ -187,7 +187,6 @@ fn tokio_run_command(command: Command, server_connection: StdUnixStream) -> anyh
|
||||||
name: Some(args.database),
|
name: Some(args.database),
|
||||||
privs: vec![],
|
privs: vec![],
|
||||||
json: false,
|
json: false,
|
||||||
// TODO: use this to mimic the old editor-finding logic
|
|
||||||
editor: None,
|
editor: None,
|
||||||
yes: false,
|
yes: false,
|
||||||
};
|
};
|
||||||
|
|
|
@ -299,7 +299,6 @@ async fn show_users(
|
||||||
|
|
||||||
server_connection.send(Request::Exit).await?;
|
server_connection.send(Request::Exit).await?;
|
||||||
|
|
||||||
// TODO: print databases where user has privileges
|
|
||||||
if args.json {
|
if args.json {
|
||||||
println!(
|
println!(
|
||||||
"{}",
|
"{}",
|
||||||
|
|
|
@ -47,7 +47,6 @@ pub async fn handle_command(
|
||||||
}
|
}
|
||||||
|
|
||||||
async fn socket_activate(config: ServerConfig) -> anyhow::Result<()> {
|
async fn socket_activate(config: ServerConfig) -> anyhow::Result<()> {
|
||||||
// TODO: allow getting socket path from other socket activation sources
|
|
||||||
let conn = get_socket_from_systemd().await?;
|
let conn = get_socket_from_systemd().await?;
|
||||||
let uid = conn.peer_cred()?.uid();
|
let uid = conn.peer_cred()?.uid();
|
||||||
let unix_user = UnixUser::from_uid(uid)?;
|
let unix_user = UnixUser::from_uid(uid)?;
|
||||||
|
|
|
@ -32,8 +32,6 @@ use crate::{
|
||||||
|
|
||||||
// TODO: consider using a connection pool
|
// TODO: consider using a connection pool
|
||||||
|
|
||||||
// TODO: use tracing for login, so we can scope the log messages per incoming connection
|
|
||||||
|
|
||||||
pub async fn listen_for_incoming_connections(
|
pub async fn listen_for_incoming_connections(
|
||||||
socket_path: Option<PathBuf>,
|
socket_path: Option<PathBuf>,
|
||||||
config: ServerConfig,
|
config: ServerConfig,
|
||||||
|
|
Loading…
Reference in New Issue