Fix cli mode of edit-db-privs #71

New Issue

oysteikt · 2024-08-19T02:33:03+02:00

oysteikt commented

2024-08-19 02:33:03 +02:00

In the current implementation of edit-db-privs with the -p flag, the user would need to provide all privileges for all users on all databases. The intended effect is to modify the privileges which have matching users and databases, as well as add any new db-user pairs, but the resulting diff would remove any existing privileges that the user forgot to include in their -p flags.

However, if we make it so that the -p flag only modifies/adds new stuff, it would make it impossible to remove privileges. Maybe we should think of something new?

In the current implementation of `edit-db-privs` with the `-p` flag, the user would need to provide all privileges for all users on all databases. The intended effect is to modify the privileges which have matching users and databases, as well as add any new db-user pairs, but the resulting diff would remove any existing privileges that the user forgot to include in their `-p` flags. However, if we make it so that the `-p` flag only modifies/adds new stuff, it would make it impossible to remove privileges. Maybe we should think of something new?

oysteikt added the bug question labels 2024-08-19 02:33:03 +02:00

oysteikt referenced this issue

2024-08-19 19:47:23 +02:00

Either disable or fix `edit-db-privs`' `-p` flag before release #80

oysteikt commented

2025-11-10 14:43:55 +01:00

chmod does something fundamentally similar, but with less variables at play. Could we take inspiration from here?

`chmod` does something fundamentally similar, but with less variables at play. Could we take inspiration from here?

oysteikt started working 2025-11-25 11:21:52 +01:00

oysteikt commented

2025-11-25 11:22:03 +01:00

Fixed in 03a761a0ff