Fix performance regressions

vegardbm commented

2026-07-25 15:28:26 +02:00

Owner

Several regressions in performance after switching to CBZ.
Most importantly it takes a heck of a long time to load a comic and to go back to the overview.
Startup time is pretty bad.

Several regressions in performance after switching to CBZ. Most importantly it takes a heck of a long time to load a comic and to go back to the overview. Startup time is pretty bad.

vegardbm added the performance label 2026-07-25 15:28:26 +02:00

vegardbm commented

2026-07-25 22:51:59 +02:00

Author

Owner

I found one important code snippet which causes most of the performance regression:

for volume in metadata.volumes {
    for chapter in volume.chapters {
        sum += chapter.images.count
    }
}

I found one important code snippet which causes most of the performance regression: ```swift for volume in metadata.volumes { for chapter in volume.chapters { sum += chapter.images.count } } ```

vegardbm commented

2026-07-25 23:15:32 +02:00

Author

Owner

The reason this is an issue is a combination of the method where this snippet resides is called often, the accesses are not cheap because they have significant indirection. The access is related to how flatbuffers work.

vegardbm referenced a pull request that will close this issue

2026-07-25 23:50:42 +02:00

perf: cache amount of images in comic #25

vegardbm closed this issue

2026-07-25 23:51:04 +02:00

Fix performance regressions #24