Commit Graph

1842 Commits

Author SHA1 Message Date
Eric Wong
4c80121bba buffer2array: extra unit tests (for PHP magic quote escapes)
Make the unit tests compile correctly without using xstrdup.

Also, use "static inline" instead of "inline static": certain
compilers or cflags are likely to complain about the latter.

git-svn-id: https://svn.musicpd.org/mpd/trunk@4892 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-10-10 19:37:32 +00:00
Eric Wong
e0a8c17957 mp3_plugin.c: fix compilation with -pedantic and/or gcc 2.95
git-svn-id: https://svn.musicpd.org/mpd/trunk@4876 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-10-06 18:01:12 +00:00
Warren Dukes
e198826606 put back np's supperrior buffer2array, and fix my bug fix from change 4872
git-svn-id: https://svn.musicpd.org/mpd/trunk@4875 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-10-06 10:33:27 +00:00
Eric Wong
e3222d807a Revert buffer2array() behavior back to tried and true 0.11.x version
Warren's fix in r4872 made phpMp work again, but also broke
the unit tests completely (they work in this version).

The version in 0.12.0 is far too buggy (it was from mpd-ke, what
do you expect?).  This one passes all the unit tests that the
mpd-ke one passed, and should also work with phpMp when used
with PHP magic quotes.

This also means we can search on 100 (or more) tags at once, so
no more arbitrary limits other than system memory.

To run the unit tests, just do this:
gcc -o t -DUNIT_TEST=1 src/buffer2array.c && ./t && echo OK

git-svn-id: https://svn.musicpd.org/mpd/trunk@4874 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-10-06 08:54:43 +00:00
Warren Dukes
1a51bfb84a fix escaping in quotes. (Now phpMp works again!)
git-svn-id: https://svn.musicpd.org/mpd/trunk@4872 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-10-06 02:25:58 +00:00
Warren Dukes
00719544eb add a sanity check assert
git-svn-id: https://svn.musicpd.org/mpd/trunk@4869 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-10-03 03:06:30 +00:00
Warren Dukes
d3040d1eb5 fix the segfault for when no audio_output is found and none is detected (bug found by normalperson!!!)
git-svn-id: https://svn.musicpd.org/mpd/trunk@4868 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-10-03 02:57:01 +00:00
Warren Dukes
347a33b009 cleanup flushWarningBuffer() and make some for() loops in audio.c look and do something sane.
git-svn-id: https://svn.musicpd.org/mpd/trunk@4867 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-10-03 02:22:37 +00:00
Warren Dukes
648f48ce3b handle invalid xing tags better.
git-svn-id: https://svn.musicpd.org/mpd/trunk@4866 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-10-03 00:58:20 +00:00
J. Alexander Treuman
4d6db2eb37 Bumping version numbers to 0.12.0.
git-svn-id: https://svn.musicpd.org/mpd/trunk@4819 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-09-22 14:05:01 +00:00
J. Alexander Treuman
a45e2f399c Updating release date in ChangeLog.
git-svn-id: https://svn.musicpd.org/mpd/trunk@4818 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-09-22 14:04:06 +00:00
Eric Wong
5ece12982a outputBuffer: avoid out-of-bounds-error in clearOutputBuffer()
I'm still not entirely certain why we index cb->metaChunkSet[]
with currentChunk (and not currentMetaChunk), but shank told me
that currentChunk is correct...

git-svn-id: https://svn.musicpd.org/mpd/trunk@4814 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-09-21 08:27:24 +00:00
Eric Wong
64e8332fe5 signal_check: [trivial] make __caught_signals array static
git-svn-id: https://svn.musicpd.org/mpd/trunk@4780 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-09-15 08:56:05 +00:00
J. Alexander Treuman
cb8da28ad7 Updating version numbers to rc4.
git-svn-id: https://svn.musicpd.org/mpd/trunk@4778 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-09-15 01:38:56 +00:00
J. Alexander Treuman
528429b028 Filling in link to wiki for audio outputs in mpdconf.example
git-svn-id: https://svn.musicpd.org/mpd/trunk@4776 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-09-15 00:48:46 +00:00
J. Alexander Treuman
f55415a2b1 Removing tree from TODO
git-svn-id: https://svn.musicpd.org/mpd/trunk@4775 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-09-15 00:47:57 +00:00
Eric Wong
a5c88ce51b m4: add pkg.m4 so users can run autogen.sh without pkg-config
They still won't be able to get pulse without pkg-config, however.

git-svn-id: https://svn.musicpd.org/mpd/trunk@4774 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-09-14 01:52:14 +00:00
J. Alexander Treuman
8da589b7df Make autogen.sh exit immediately if any of the tools it runs fails.
git-svn-id: https://svn.musicpd.org/mpd/trunk@4773 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-09-13 22:29:57 +00:00
J. Alexander Treuman
98424851d8 I can't believe qball is correcting my typos.
git-svn-id: https://svn.musicpd.org/mpd/trunk@4771 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-09-13 17:04:14 +00:00
Eric Wong
6f0926ff3f configure.ac: replace double quotes AC_MSG_ERROR with brackets
double quotes are printed out in the corresponding shell code

git-svn-id: https://svn.musicpd.org/mpd/trunk@4770 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-09-13 08:03:37 +00:00
J. Alexander Treuman
6d5950bbe7 Typo found by bensonk.
git-svn-id: https://svn.musicpd.org/mpd/trunk@4769 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-09-12 23:23:29 +00:00
J. Alexander Treuman
bb5e87bd3d New example config.
git-svn-id: https://svn.musicpd.org/mpd/trunk@4768 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-09-12 23:16:14 +00:00
J. Alexander Treuman
0c33afabe9 replaygain -> ReplayGain in docs
git-svn-id: https://svn.musicpd.org/mpd/trunk@4767 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-09-12 22:28:58 +00:00
J. Alexander Treuman
ac7dd43ad8 Note that mpd will scan for an audio output if none is specified.
git-svn-id: https://svn.musicpd.org/mpd/trunk@4766 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-09-12 21:52:49 +00:00
J. Alexander Treuman
32c5f5a8f0 Deleting bs directory from svn.
git-svn-id: https://svn.musicpd.org/mpd/trunk@4765 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-09-12 21:50:09 +00:00
Eric Wong
48b54d7a71 m4/lib*FLAC.m4: fix typos, -INONE/include no longer mis-added to CFLAGS
git-svn-id: https://svn.musicpd.org/mpd/trunk@4763 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-09-12 06:50:21 +00:00
Eric Wong
ca84702d8d tag.c: remove unnecessary #includes
git-svn-id: https://svn.musicpd.org/mpd/trunk@4762 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-09-11 23:45:25 +00:00
Eric Wong
a077a38a85 configure.ac: fix tremor detection usage
git-svn-id: https://svn.musicpd.org/mpd/trunk@4761 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-09-11 23:41:07 +00:00
Qball Cow
f3aa34badb Hopefully fix endian problem mac x86/ppc
git-svn-id: https://svn.musicpd.org/mpd/trunk@4750 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-09-09 10:01:25 +00:00
Eric Wong
f5c7f3da31 utils.c: fix xrealloc
(based on suggested patch by Jan-Benedict Glaw):
> While hacking mpd, I noticed that an assert()ion in xrealloc is wrong.
> A null size is perfectly legal, so we shouldn't assert on that.

Since some C libraries return NULL when size == 0, we'll make
sure we get a free()-able pointer since some of those C
libraries also barf on free(NULL).

git-svn-id: https://svn.musicpd.org/mpd/trunk@4740 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-09-07 19:26:51 +00:00
Eric Wong
12d253118d configure.ac: fix an obvious typo for setting mpcdec libs
git-svn-id: https://svn.musicpd.org/mpd/trunk@4739 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-09-06 09:29:06 +00:00
Eric Wong
b78b0a7f09 remove bs; oops, didn't mean to commit that
git-svn-id: https://svn.musicpd.org/mpd/trunk@4738 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-09-06 09:28:16 +00:00
Eric Wong
412cb1ee10 bs: a work in progress..
git-svn-id: https://svn.musicpd.org/mpd/trunk@4737 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-09-06 09:26:51 +00:00
Eric Wong
7b6d45f50f gcc.h: make sure __GNUC__ is defined before checking it's value
git-svn-id: https://svn.musicpd.org/mpd/trunk@4724 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-08-30 07:56:22 +00:00
J. Alexander Treuman
76779449b9 Fixing up the new 0.12 ChangeLog entry some more.
git-svn-id: https://svn.musicpd.org/mpd/trunk@4722 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-08-28 23:50:38 +00:00
J. Alexander Treuman
0e9114e3ad Removing id3v1_encoding from 0.12 ChangeLog entry, since it was already listed in the 0.11.5 entry. Also correcting a couple of typos in that old entry.
git-svn-id: https://svn.musicpd.org/mpd/trunk@4721 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-08-28 23:47:15 +00:00
J. Alexander Treuman
806acdd4f4 Rearrange mpd.conf.5 and conf.[ch] to use the more logical ordering of config parameters that the new (yet to be committed) mpdconf.example will use.
git-svn-id: https://svn.musicpd.org/mpd/trunk@4715 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-08-28 20:47:50 +00:00
J. Alexander Treuman
6018a1b4f8 Note that default for metadata_to_use doesn't include comments
git-svn-id: https://svn.musicpd.org/mpd/trunk@4714 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-08-28 20:10:40 +00:00
J. Alexander Treuman
26a6ba7a77 Add id3v1_encoding to the mpd.conf man page.
git-svn-id: https://svn.musicpd.org/mpd/trunk@4713 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-08-28 19:34:31 +00:00
J. Alexander Treuman
648b03e4a9 Update ChangeLog. Please keep this up to date as you make changes from now on.
git-svn-id: https://svn.musicpd.org/mpd/trunk@4710 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-08-28 18:12:18 +00:00
J. Alexander Treuman
00b4ce40a8 Removing mp1/mp2 from TODO
git-svn-id: https://svn.musicpd.org/mpd/trunk@4707 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-08-28 16:47:22 +00:00
J. Alexander Treuman
72640290cf Updating INSTALL
git-svn-id: https://svn.musicpd.org/mpd/trunk@4706 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-08-28 16:44:29 +00:00
J. Alexander Treuman
ebba9491ca Adding directions for updating to 0.12.0 to UPGRADING
git-svn-id: https://svn.musicpd.org/mpd/trunk@4705 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-08-28 15:42:32 +00:00
Eric Wong
90847fc881 Replace strdup and {c,re,m}alloc with x* variants to check for OOM errors
I'm checking for zero-size allocations and assert()-ing them,
so we can more easily get backtraces and debug problems, but we'll
also allow -DNDEBUG people to live on the edge if they wish.

We do not rely on errno when checking for OOM errors because
some implementations of malloc do not set it, and malloc
is commonly overridden by userspace wrappers.

I've spent some time looking through the source and didn't find any
obvious places where we would explicitly allocate 0 bytes, so we
shouldn't trip any of those assertions.

We also avoid allocating zero bytes because C libraries don't
handle this consistently (some return NULL, some not); and it's
dangerous either way.

git-svn-id: https://svn.musicpd.org/mpd/trunk@4690 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-08-26 06:25:57 +00:00
Eric Wong
be554c2596 audioOutputs_oss: [trivial] make loop interation consistent with others
git-svn-id: https://svn.musicpd.org/mpd/trunk@4689 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-08-26 06:25:52 +00:00
Eric Wong
f3981eab58 audio.c: [trivial] remove unnecessary include
git-svn-id: https://svn.musicpd.org/mpd/trunk@4688 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-08-26 06:25:49 +00:00
Eric Wong
45f28394c0 command.c: rerun mpd-indent.sh, no code changes
leave out initCommands to keep jat happy, and keep labels
at the left hand side

git-svn-id: https://svn.musicpd.org/mpd/trunk@4687 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-08-26 06:25:44 +00:00
J. Alexander Treuman
5b7c3c8707 Fix an esoteric gcc warning
git-svn-id: https://svn.musicpd.org/mpd/trunk@4684 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-08-25 00:29:41 +00:00
Eric Wong
64a4c635de audiofile_plugin: use afSetVirtualSampleFormat, too
This finally fixes a bug from over two years ago playing a wave file
(oprah.wav) with the following characteristics (from sfinfo):

File Format    Microsoft RIFF WAVE Format (wave)
Data Format    8-bit integer (unsigned, little endian)
Audio Data     986827 bytes begins at offset 58 (3a hex)
1 channel, 986827 frames
Sampling Rate  22050.00 Hz
Duration       44.754 seconds

Of course, this has been regression tested with all the files
that the previous commit got working.  Thanks to Michael Pruett
(audiofile author) for the hint and shame on me for forgetting
about it for over two years :x

git-svn-id: https://svn.musicpd.org/mpd/trunk@4682 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-08-24 21:59:19 +00:00
Eric Wong
b8fe818ae7 audiofile_plugin: fix for playing mono .au files with 8000Hz sample rate
Use the 'Virtual' variants of afGetSampleFormat, afGetChannels,
afGetVirtualFrameSize in the audiofile library, since it already does
the necessary abstraction for us.

Of course, I've regression tested these changes against my
standard 44100Hz/2ch/16bit wave files and they continue to play
fine.

Files tested:
english.au (Linus Torvalds pronouncing 'Linux' in English)
B01.Red_Bright_Heart.au (Chinese opera, sounds correct to me even though
I don't actually understand the words)

git-svn-id: https://svn.musicpd.org/mpd/trunk@4681 09075e82-0dd4-0310-85a5-a0d7c8717e4f
2006-08-24 20:54:40 +00:00