From fcf65de46bb8987c1237d7114d3b8e411b8f0d2a Mon Sep 17 00:00:00 2001 From: Max Kellermann Date: Wed, 18 Feb 2009 19:08:52 +0100 Subject: [PATCH] mp4ff: always free the mp4ff_read_sample() buffer When mp4ff_read_sample() returns a value bigger than zero, it guarantees that the buffer is set. Remove the check. --- src/decoder/mp4ff_plugin.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/decoder/mp4ff_plugin.c b/src/decoder/mp4ff_plugin.c index ddbb768e3..6e799b7ac 100644 --- a/src/decoder/mp4ff_plugin.c +++ b/src/decoder/mp4ff_plugin.c @@ -287,8 +287,8 @@ mp4_decode(struct decoder *mpd_decoder, struct input_stream *input_stream) sample_buffer = faacDecDecode(decoder, &frame_info, mp4_buffer); #endif - if (mp4_buffer) - free(mp4_buffer); + free(mp4_buffer); + if (frame_info.error > 0) { g_warning("faad2 error: %s\n", faacDecGetErrorMessage(frame_info.error));