From e776c605adeb984aae290cdff38c5f8dd0cd291e Mon Sep 17 00:00:00 2001 From: Thomas Jansen Date: Fri, 4 Feb 2011 10:22:00 +0100 Subject: [PATCH] output/httpd: initialize unflushed_input This fixes the following valgrind warning occuring on the first call of httpd_output_read_page: ==20124== Conditional jump or move depends on uninitialised value(s) ==20124== at 0x425E65: httpd_output_read_page (httpd_output_plugin.c:240) ==20124== by 0x426087: httpd_output_open (httpd_output_plugin.c:279) ==20124== by 0x41D862: ao_open (output_plugin.h:206) ==20124== by 0x41E133: audio_output_task (output_thread.c:590) --- NEWS | 2 ++ src/output/httpd_output_plugin.c | 1 + 2 files changed, 3 insertions(+) diff --git a/NEWS b/NEWS index 994bdf407..5316279f5 100644 --- a/NEWS +++ b/NEWS @@ -2,6 +2,8 @@ ver 0.16.2 (2011/??/??) * decoder: - tremor: fix configure test - gme: detect end of song +* output: + - httpd: fix uninitialized variable ver 0.16.1 (2011/01/09) diff --git a/src/output/httpd_output_plugin.c b/src/output/httpd_output_plugin.c index 72994018a..27103c3f8 100644 --- a/src/output/httpd_output_plugin.c +++ b/src/output/httpd_output_plugin.c @@ -123,6 +123,7 @@ httpd_output_init(G_GNUC_UNUSED const struct audio_format *audio_format, /* initialize metadata */ httpd->metadata = NULL; + httpd->unflushed_input = 0; /* initialize encoder */