From e5137706d18ba4d42a57bf90b4d1b9d97af1ecf8 Mon Sep 17 00:00:00 2001 From: Max Kellermann Date: Sun, 2 Nov 2008 17:32:40 +0100 Subject: [PATCH] ffmpeg: fix boolean inversion in ffmpeg_tag() ffmpeg_tag() deleted the tag when ffmpeg_helper() returned success. The return value was interpreted incorrectly, it should return the tag on success. --- src/decoder/ffmpeg_plugin.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/decoder/ffmpeg_plugin.c b/src/decoder/ffmpeg_plugin.c index 445d46512..b9debd1b8 100644 --- a/src/decoder/ffmpeg_plugin.c +++ b/src/decoder/ffmpeg_plugin.c @@ -338,7 +338,7 @@ static struct tag *ffmpeg_tag(const char *file) base.tag = tag_new(); ret = ffmpeg_helper(&input, ffmpeg_tag_internal, &base); - if (ret) { + if (!ret) { tag_free(base.tag); base.tag = NULL; }