From dfea6b7cdd50ad14082b1848104d580b4380471b Mon Sep 17 00:00:00 2001 From: Max Kellermann Date: Thu, 26 Feb 2009 22:10:58 +0100 Subject: [PATCH] mvp: fixed default device detection The check "open()!=0" is wrong, you have to write "open()>=0", because -1 means error, and 0 is a valid file handle. --- NEWS | 1 + src/output/mvp_plugin.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 324a8e4b8..322a32855 100644 --- a/NEWS +++ b/NEWS @@ -20,6 +20,7 @@ ver 0.15 - (200?/??/??) - mvp: fall back to stereo - mvp: fall back to 16 bit audio samples - mvp: check for reopen errors + - mvp: fixed default device detection * commands: - "playlistinfo" supports a range now - added "sticker database", command "sticker", which allows clients diff --git a/src/output/mvp_plugin.c b/src/output/mvp_plugin.c index b9004029b..976a2c2b5 100644 --- a/src/output/mvp_plugin.c +++ b/src/output/mvp_plugin.c @@ -114,7 +114,7 @@ mvp_output_test_default_device(void) fd = open("/dev/adec_pcm", O_WRONLY); - if (fd) { + if (fd >= 0) { close(fd); return true; }