From df33a898d7c1ba3228135bc27a29249923635a36 Mon Sep 17 00:00:00 2001 From: Max Kellermann Date: Thu, 4 Apr 2019 10:24:10 +0200 Subject: [PATCH] zeroconf/Bonjour: fix OnSocketReady() return value Keep the SocketMonitor registered. This wrong return value was added 6 years ago in commit 72cf8dd8a0451a4d9dae14a68483dc31adc61b09, andd apparently, nobody ever noticed. --- NEWS | 1 + src/zeroconf/ZeroconfBonjour.cxx | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 6712fdf37..ae1e4a3b4 100644 --- a/NEWS +++ b/NEWS @@ -1,6 +1,7 @@ ver 0.21.8 (not yet released) * output - httpd: add missing mutex lock +* fix Bonjour bug * fix build failure with GCC 9 ver 0.21.7 (2019/04/03) diff --git a/src/zeroconf/ZeroconfBonjour.cxx b/src/zeroconf/ZeroconfBonjour.cxx index 104116ebc..6c3b98240 100644 --- a/src/zeroconf/ZeroconfBonjour.cxx +++ b/src/zeroconf/ZeroconfBonjour.cxx @@ -50,7 +50,7 @@ protected: /* virtual methods from class SocketMonitor */ bool OnSocketReady(gcc_unused unsigned flags) noexcept override { DNSServiceProcessResult(service_ref); - return false; + return true; } };