From dc5ef9ad0103b19546ca22adff094184380e9f2e Mon Sep 17 00:00:00 2001
From: Max Kellermann <max@duempel.org>
Date: Tue, 21 Jan 2014 22:43:04 +0100
Subject: [PATCH] db/upnp: simplify GetSong()

---
 src/db/UpnpDatabasePlugin.cxx | 42 +++++++++++++++++------------------
 1 file changed, 20 insertions(+), 22 deletions(-)

diff --git a/src/db/UpnpDatabasePlugin.cxx b/src/db/UpnpDatabasePlugin.cxx
index c778ca34e..5ce09e31e 100644
--- a/src/db/UpnpDatabasePlugin.cxx
+++ b/src/db/UpnpDatabasePlugin.cxx
@@ -219,31 +219,29 @@ UpnpDatabase::ReturnSong(const LightSong *_song) const
 const LightSong *
 UpnpDatabase::GetSong(const char *uri, Error &error) const
 {
-	UpnpSong *song = nullptr;
 	auto vpath = stringToTokens(uri, "/", true);
-	if (vpath.size() >= 2) {
-		ContentDirectoryService server;
-		if (!m_superdir->getServer(vpath[0].c_str(), server, error))
-			return nullptr;
-
-		vpath.erase(vpath.begin());
-		UPnPDirObject dirent;
-		if (vpath[0].compare(rootid)) {
-			std::string objid;
-			if (!Namei(server, vpath, objid, dirent, error))
-				return nullptr;
-		} else {
-			if (!ReadNode(server, vpath.back().c_str(), dirent,
-				      error))
-				return nullptr;
-		}
-
-		song = new UpnpSong(std::move(dirent), uri);
-	}
-	if (song == nullptr)
+	if (vpath.size() < 2) {
 		error.Format(db_domain, DB_NOT_FOUND, "No such song: %s", uri);
+		return nullptr;
+	}
 
-	return song;
+	ContentDirectoryService server;
+	if (!m_superdir->getServer(vpath[0].c_str(), server, error))
+		return nullptr;
+
+	vpath.erase(vpath.begin());
+	UPnPDirObject dirent;
+	if (vpath[0].compare(rootid)) {
+		std::string objid;
+		if (!Namei(server, vpath, objid, dirent, error))
+			return nullptr;
+	} else {
+		if (!ReadNode(server, vpath.back().c_str(), dirent,
+			      error))
+			return nullptr;
+	}
+
+	return new UpnpSong(std::move(dirent), uri);
 }
 
 /**