diff --git a/NEWS b/NEWS index cc13617b9..69121ac7f 100644 --- a/NEWS +++ b/NEWS @@ -1,4 +1,6 @@ ver 0.21.12 (not yet released) +* decoder + - opus: ignore case in replay gain tag names * Windows - support backslash in relative URIs loaded from playlists diff --git a/src/decoder/plugins/OpusTags.cxx b/src/decoder/plugins/OpusTags.cxx index c0a14fa89..76ea63e6e 100644 --- a/src/decoder/plugins/OpusTags.cxx +++ b/src/decoder/plugins/OpusTags.cxx @@ -22,12 +22,12 @@ #include "lib/xiph/XiphTags.hxx" #include "tag/Handler.hxx" #include "tag/ParseName.hxx" +#include "util/ASCII.hxx" #include "ReplayGainInfo.hxx" #include #include -#include #include gcc_pure @@ -46,7 +46,7 @@ ScanOneOpusTag(const char *name, const char *value, ReplayGainInfo *rgi, TagHandler &handler) noexcept { - if (rgi != nullptr && strcmp(name, "R128_TRACK_GAIN") == 0) { + if (rgi != nullptr && StringEqualsCaseASCII(name, "R128_TRACK_GAIN")) { /* R128_TRACK_GAIN is a Q7.8 fixed point number in dB */ @@ -54,7 +54,8 @@ ScanOneOpusTag(const char *name, const char *value, long l = strtol(value, &endptr, 10); if (endptr > value && *endptr == 0) rgi->track.gain = double(l) / 256.; - } else if (rgi != nullptr && strcmp(name, "R128_ALBUM_GAIN") == 0) { + } else if (rgi != nullptr && + StringEqualsCaseASCII(name, "R128_ALBUM_GAIN")) { /* R128_ALBUM_GAIN is a Q7.8 fixed point number in dB */