From a573d57de89ab08ef56bc83aabfb40bb9cdfc508 Mon Sep 17 00:00:00 2001 From: Max Kellermann Date: Wed, 6 Sep 2023 16:10:21 +0200 Subject: [PATCH] tag/Builder: remove unnecessary explicit AddItem() overload --- src/tag/Builder.cxx | 6 ------ src/tag/Builder.hxx | 9 --------- 2 files changed, 15 deletions(-) diff --git a/src/tag/Builder.cxx b/src/tag/Builder.cxx index c8ae74e63..699755170 100644 --- a/src/tag/Builder.cxx +++ b/src/tag/Builder.cxx @@ -213,12 +213,6 @@ TagBuilder::AddItem(TagType type, std::string_view value) noexcept AddItemInternal(type, value); } -void -TagBuilder::AddItem(TagType type, const char *value) noexcept -{ - AddItem(type, std::string_view(value)); -} - void TagBuilder::AddEmptyItem(TagType type) noexcept { diff --git a/src/tag/Builder.hxx b/src/tag/Builder.hxx index 94dd7028b..b16fa96bd 100644 --- a/src/tag/Builder.hxx +++ b/src/tag/Builder.hxx @@ -132,15 +132,6 @@ public: */ void AddItem(TagType type, std::string_view value) noexcept; - /** - * Appends a new tag item. - * - * @param type the type of the new tag item - * @param value the value of the tag item (null-terminated) - */ - [[gnu::nonnull]] - void AddItem(TagType type, const char *value) noexcept; - /** * Appends a new tag item with an empty value. Do not use * this unless you know what you're doing - because usually,