From 91438b6540d966edf56227a975db92465f7625a0 Mon Sep 17 00:00:00 2001 From: Max Kellermann Date: Thu, 31 Aug 2017 15:02:15 +0200 Subject: [PATCH] output/Interface: the default Pause() implementation fails Fixes regression from commit 31bad5f7af6cb59a276319a9fc1bb9ceebdc79ff: if Pause() returns true, the output thread is running a busy loop, causing 100% CPU usage, instead of just closing the output. Closes #105 --- src/output/Interface.hxx | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/output/Interface.hxx b/src/output/Interface.hxx index 83737df5b..70e47b273 100644 --- a/src/output/Interface.hxx +++ b/src/output/Interface.hxx @@ -141,7 +141,10 @@ public: * @return false on error (output will be closed by caller), * true for continue to pause */ - virtual bool Pause() noexcept { return true; } + virtual bool Pause() noexcept { + /* fail because this method is not implemented */ + return false; + } }; #endif