From 7f9a2f8adbf7de339d1f2ddb0e7467303d339ed4 Mon Sep 17 00:00:00 2001
From: Max Kellermann <max@musicpd.org>
Date: Fri, 18 Aug 2017 18:08:06 +0200
Subject: [PATCH] event/Loop: schedule and cancel the WakeFD in Run()

This is only needed while Run() is alive, and moving it there avoids
problems with thread-checking assertions.
---
 src/event/Loop.cxx | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/src/event/Loop.cxx b/src/event/Loop.cxx
index 93fdd0b1f..c74fa86c8 100644
--- a/src/event/Loop.cxx
+++ b/src/event/Loop.cxx
@@ -23,6 +23,7 @@
 #include "SocketMonitor.hxx"
 #include "IdleMonitor.hxx"
 #include "DeferredMonitor.hxx"
+#include "util/ScopeExit.hxx"
 
 #include <algorithm>
 
@@ -30,17 +31,12 @@ EventLoop::EventLoop()
 	:SocketMonitor(*this)
 {
 	SocketMonitor::Open(SocketDescriptor(wake_fd.Get()));
-	SocketMonitor::Schedule(SocketMonitor::READ);
 }
 
 EventLoop::~EventLoop()
 {
 	assert(idle.empty());
 	assert(timers.empty());
-
-	/* this is necessary to get a well-defined destruction
-	   order */
-	SocketMonitor::Cancel();
 }
 
 void
@@ -144,6 +140,9 @@ EventLoop::Run()
 	assert(!quit);
 	assert(busy);
 
+	SocketMonitor::Schedule(SocketMonitor::READ);
+	AtScopeExit(this) { SocketMonitor::Cancel(); };
+
 	do {
 		now = std::chrono::steady_clock::now();
 		again = false;