From 6dc708f53fabd301b0c7c04acf966fdfbdafd184 Mon Sep 17 00:00:00 2001
From: Max Kellermann <mk@cm4all.com>
Date: Wed, 22 Nov 2023 11:58:40 +0100
Subject: [PATCH] net/SocketDescriptor: use method GetOption() internally
---
src/net/SocketDescriptor.cxx | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/src/net/SocketDescriptor.cxx b/src/net/SocketDescriptor.cxx
index 11624a2d4..ecf339df4 100644
--- a/src/net/SocketDescriptor.cxx
+++ b/src/net/SocketDescriptor.cxx
@@ -191,12 +191,9 @@ SocketDescriptor::CreateSocketPairNonBlock(int domain, int type, int protocol,
int
SocketDescriptor::GetError() const noexcept
{
- assert(IsDefined());
-
int s_err = 0;
- socklen_t s_err_size = sizeof(s_err);
- return getsockopt(fd, SOL_SOCKET, SO_ERROR,
- (char *)&s_err, &s_err_size) == 0
+ return GetOption(SOL_SOCKET, SO_ERROR,
+ &s_err, sizeof(s_err)) == sizeof(s_err)
? s_err
: errno;
}