diff --git a/NEWS b/NEWS index 1b0fc1e59..8b8e6591a 100644 --- a/NEWS +++ b/NEWS @@ -2,6 +2,8 @@ ver 0.20.21 (not yet released) * database - proxy: add "password" setting - proxy: support tags "ArtistSort", "AlbumArtistSort", "AlbumSort" +* output + - httpd: remove broken DLNA support code ver 0.20.20 (2018/05/22) * protocol diff --git a/src/output/plugins/httpd/HttpdClient.cxx b/src/output/plugins/httpd/HttpdClient.cxx index d5a423d7d..9d3b38c16 100644 --- a/src/output/plugins/httpd/HttpdClient.cxx +++ b/src/output/plugins/httpd/HttpdClient.cxx @@ -122,15 +122,6 @@ HttpdClient::HandleLine(const char *line) return true; } - if (StringEqualsCaseASCII(line, "transferMode.dlna.org: Streaming", 32)) { - /* Send as dlna */ - dlna_streaming_requested = true; - /* metadata is not supported by dlna streaming, so disable it */ - metadata_supported = false; - metadata_requested = false; - return true; - } - /* expect more request headers */ return true; } @@ -148,22 +139,7 @@ HttpdClient::SendResponse() assert(state == RESPONSE); - if (dlna_streaming_requested) { - snprintf(buffer, sizeof(buffer), - "HTTP/1.1 206 OK\r\n" - "Content-Type: %s\r\n" - "Content-Length: 10000\r\n" - "Content-RangeX: 0-1000000/1000000\r\n" - "transferMode.dlna.org: Streaming\r\n" - "Accept-Ranges: bytes\r\n" - "Connection: close\r\n" - "realTimeInfo.dlna.org: DLNA.ORG_TLAG=*\r\n" - "contentFeatures.dlna.org: DLNA.ORG_OP=01;DLNA.ORG_CI=0\r\n" - "\r\n", - httpd.content_type); - response = buffer; - - } else if (metadata_requested) { + if (metadata_requested) { allocated = icy_server_metadata_header(httpd.name, httpd.genre, httpd.website, @@ -202,7 +178,6 @@ HttpdClient::HttpdClient(HttpdOutput &_httpd, int _fd, EventLoop &_loop, state(REQUEST), queue_size(0), head_method(false), - dlna_streaming_requested(false), metadata_supported(_metadata_supported), metadata_requested(false), metadata_sent(true), metaint(8192), /*TODO: just a std value */ diff --git a/src/output/plugins/httpd/HttpdClient.hxx b/src/output/plugins/httpd/HttpdClient.hxx index 3cc337e94..a890833ba 100644 --- a/src/output/plugins/httpd/HttpdClient.hxx +++ b/src/output/plugins/httpd/HttpdClient.hxx @@ -82,11 +82,6 @@ class HttpdClient final */ bool head_method; - /** - * If DLNA streaming was an option. - */ - bool dlna_streaming_requested; - /* ICY */ /**