From f39d2d33c01d2c249d45bf7b43283b6ca21c913d Mon Sep 17 00:00:00 2001 From: Max Kellermann Date: Tue, 23 Apr 2019 14:08:21 +0200 Subject: [PATCH 1/4] python/build/libs.py: upgrade Boost to 1.70.0 --- python/build/libs.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/python/build/libs.py b/python/build/libs.py index ac7984afb..103c67b09 100644 --- a/python/build/libs.py +++ b/python/build/libs.py @@ -392,7 +392,7 @@ libnfs = AutotoolsProject( ) boost = BoostProject( - 'http://downloads.sourceforge.net/project/boost/boost/1.69.0/boost_1_69_0.tar.bz2', - '8f32d4617390d1c2d16f26a27ab60d97807b35440d45891fa340fc2648b04406', + 'http://downloads.sourceforge.net/project/boost/boost/1.70.0/boost_1_70_0.tar.bz2', + '430ae8354789de4fd19ee52f3b1f739e1fba576f0aded0897c3c2bc00fb38778', 'include/boost/version.hpp', ) From 3a0d6d96c138a303bdc5ee06fd2e11a03e8f1404 Mon Sep 17 00:00:00 2001 From: Max Kellermann Date: Tue, 23 Apr 2019 14:04:33 +0200 Subject: [PATCH 2/4] input/smbclient: wrap in MaybeBufferedInputStream This enables the input buffer for remote files and caches file contents in MPD. Closes https://github.com/MusicPlayerDaemon/MPD/issues/376 --- NEWS | 2 ++ src/input/plugins/SmbclientInputPlugin.cxx | 6 ++++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index c0c91d028..86370ba23 100644 --- a/NEWS +++ b/NEWS @@ -1,4 +1,6 @@ ver 0.21.8 (not yet released) +* input + - smbclient: download to buffer instead of throttling transfer * output - httpd: add missing mutex lock - httpd: fix use-after-free bug diff --git a/src/input/plugins/SmbclientInputPlugin.cxx b/src/input/plugins/SmbclientInputPlugin.cxx index b4b0785f8..d2ad9159e 100644 --- a/src/input/plugins/SmbclientInputPlugin.cxx +++ b/src/input/plugins/SmbclientInputPlugin.cxx @@ -22,6 +22,7 @@ #include "lib/smbclient/Mutex.hxx" #include "../InputStream.hxx" #include "../InputPlugin.hxx" +#include "../MaybeBufferedInputStream.hxx" #include "PluginUnavailable.hxx" #include "system/Error.hxx" #include "util/ASCII.hxx" @@ -112,8 +113,9 @@ input_smbclient_open(const char *uri, throw MakeErrno(e, "smbc_fstat() failed"); } - return std::make_unique(uri, mutex, - ctx, fd, st); + return std::make_unique + (std::make_unique(uri, mutex, + ctx, fd, st)); } size_t From 5e21b2db3cbddd8bae9eb78e6653a830c6c9521c Mon Sep 17 00:00:00 2001 From: Max Kellermann Date: Tue, 23 Apr 2019 14:29:42 +0200 Subject: [PATCH 3/4] doc/protocol.rst: "list file" is deprecated Closes https://github.com/MusicPlayerDaemon/MPD/issues/526 --- NEWS | 1 + doc/protocol.rst | 7 +++++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 86370ba23..15536c6cd 100644 --- a/NEWS +++ b/NEWS @@ -10,6 +10,7 @@ ver 0.21.8 (not yet released) * fix build failure with GCC 9 * fix build failure with -Ddatabase=false * systemd: add user socket unit +* doc: "list file" is deprecated ver 0.21.7 (2019/04/03) * input diff --git a/doc/protocol.rst b/doc/protocol.rst index 5ccbaa92f..a9d757194 100644 --- a/doc/protocol.rst +++ b/doc/protocol.rst @@ -861,8 +861,7 @@ The music database :command:`list {TYPE} {FILTER} [group {GROUPTYPE}]` Lists unique tags values of the specified type. ``TYPE`` can be any tag supported by - :program:`MPD` or - *file*. + :program:`MPD`. Additional arguments may specify a :ref:`filter `. The *group* keyword may be used @@ -873,6 +872,10 @@ The music database list album group albumartist + ``list file`` was implemented in an early :program:`MPD` version, + but does not appear to make a lot of sense. It still works (to + avoid breaking compatibility), but is deprecated. + .. _command_listall: :command:`listall [URI]` From cabcbb059d2a8144009e9421012ff8e9be2800af Mon Sep 17 00:00:00 2001 From: Max Kellermann Date: Tue, 23 Apr 2019 14:35:14 +0200 Subject: [PATCH 4/4] release v0.21.8 --- NEWS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 15536c6cd..a028448ab 100644 --- a/NEWS +++ b/NEWS @@ -1,4 +1,4 @@ -ver 0.21.8 (not yet released) +ver 0.21.8 (2019/04/23) * input - smbclient: download to buffer instead of throttling transfer * output