From 568deefd6814c233bf629f190290a657e66fbe33 Mon Sep 17 00:00:00 2001
From: Rosen Penev <rosenp@gmail.com>
Date: Fri, 31 Jan 2020 20:12:05 -0800
Subject: [PATCH] [clang-tidy] remove pointless void arg
Found with modernize-redundant-void-arg
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
src/CommandLine.cxx | 4 ++--
src/LogInit.cxx | 2 +-
src/archive/ArchiveList.cxx | 2 +-
src/db/update/InotifyUpdate.cxx | 2 +-
src/decoder/plugins/FlacDecoderPlugin.cxx | 2 +-
src/decoder/plugins/MikmodDecoderPlugin.cxx | 8 ++++----
src/input/plugins/CdioParanoiaInputPlugin.cxx | 2 +-
src/output/State.cxx | 2 +-
src/output/plugins/JackOutputPlugin.cxx | 2 +-
src/output/plugins/PulseOutputPlugin.cxx | 2 +-
src/unix/Daemon.cxx | 8 ++++----
11 files changed, 18 insertions(+), 18 deletions(-)
diff --git a/src/CommandLine.cxx b/src/CommandLine.cxx
index 6ea1980e7..44843301d 100644
--- a/src/CommandLine.cxx
+++ b/src/CommandLine.cxx
@@ -107,7 +107,7 @@ static constexpr OptionDef option_defs[] = {
static constexpr Domain cmdline_domain("cmdline");
gcc_noreturn
-static void version(void)
+static void version()
{
printf("Music Player Daemon " VERSION " (%s)"
"\n"
@@ -273,7 +273,7 @@ static void PrintOption(const OptionDef &opt)
}
gcc_noreturn
-static void help(void)
+static void help()
{
printf("Usage:\n"
" mpd [OPTION...] [path/to/mpd.conf]\n"
diff --git a/src/LogInit.cxx b/src/LogInit.cxx
index b3dc89e31..629716f51 100644
--- a/src/LogInit.cxx
+++ b/src/LogInit.cxx
@@ -63,7 +63,7 @@ static void redirect_logs(int fd)
}
static int
-open_log_file(void)
+open_log_file()
{
assert(!out_path.IsNull());
diff --git a/src/archive/ArchiveList.cxx b/src/archive/ArchiveList.cxx
index 50a3ccf6a..4e371c0bb 100644
--- a/src/archive/ArchiveList.cxx
+++ b/src/archive/ArchiveList.cxx
@@ -73,7 +73,7 @@ archive_plugin_from_name(const char *name) noexcept
return nullptr;
}
-void archive_plugin_init_all(void)
+void archive_plugin_init_all()
{
for (unsigned i = 0; archive_plugins[i] != nullptr; ++i) {
const ArchivePlugin *plugin = archive_plugins[i];
diff --git a/src/db/update/InotifyUpdate.cxx b/src/db/update/InotifyUpdate.cxx
index f982cbaac..af27b7bba 100644
--- a/src/db/update/InotifyUpdate.cxx
+++ b/src/db/update/InotifyUpdate.cxx
@@ -330,7 +330,7 @@ mpd_inotify_init(EventLoop &loop, Storage &storage, UpdateService &update,
}
void
-mpd_inotify_finish(void) noexcept
+mpd_inotify_finish() noexcept
{
if (inotify_source == nullptr)
return;
diff --git a/src/decoder/plugins/FlacDecoderPlugin.cxx b/src/decoder/plugins/FlacDecoderPlugin.cxx
index 988d4ba0d..ca36180ad 100644
--- a/src/decoder/plugins/FlacDecoderPlugin.cxx
+++ b/src/decoder/plugins/FlacDecoderPlugin.cxx
@@ -102,7 +102,7 @@ flac_scan_stream(InputStream &is, TagHandler &handler) noexcept
* Some glue code around FLAC__stream_decoder_new().
*/
static FlacStreamDecoder
-flac_decoder_new(void)
+flac_decoder_new()
{
FlacStreamDecoder sd;
if(!FLAC__stream_decoder_set_metadata_respond(sd.get(), FLAC__METADATA_TYPE_VORBIS_COMMENT))
diff --git a/src/decoder/plugins/MikmodDecoderPlugin.cxx b/src/decoder/plugins/MikmodDecoderPlugin.cxx
index 94b94b0d1..e365adf69 100644
--- a/src/decoder/plugins/MikmodDecoderPlugin.cxx
+++ b/src/decoder/plugins/MikmodDecoderPlugin.cxx
@@ -38,24 +38,24 @@ static constexpr Domain mikmod_domain("mikmod");
static constexpr size_t MIKMOD_FRAME_SIZE = 4096;
static BOOL
-mikmod_mpd_init(void)
+mikmod_mpd_init()
{
return VC_Init();
}
static void
-mikmod_mpd_exit(void)
+mikmod_mpd_exit()
{
VC_Exit();
}
static void
-mikmod_mpd_update(void)
+mikmod_mpd_update()
{
}
static BOOL
-mikmod_mpd_is_present(void)
+mikmod_mpd_is_present()
{
return true;
}
diff --git a/src/input/plugins/CdioParanoiaInputPlugin.cxx b/src/input/plugins/CdioParanoiaInputPlugin.cxx
index 00bd8c84a..4d1903571 100644
--- a/src/input/plugins/CdioParanoiaInputPlugin.cxx
+++ b/src/input/plugins/CdioParanoiaInputPlugin.cxx
@@ -162,7 +162,7 @@ parse_cdio_uri(const char *src)
}
static AllocatedPath
-cdio_detect_device(void)
+cdio_detect_device()
{
char **devices = cdio_get_devices_with_cap(nullptr, CDIO_FS_AUDIO,
false);
diff --git a/src/output/State.cxx b/src/output/State.cxx
index e5da97d69..3f2c801f3 100644
--- a/src/output/State.cxx
+++ b/src/output/State.cxx
@@ -80,7 +80,7 @@ audio_output_state_read(const char *line, MultipleOutputs &outputs)
}
unsigned
-audio_output_state_get_version(void)
+audio_output_state_get_version()
{
return audio_output_state_version;
}
diff --git a/src/output/plugins/JackOutputPlugin.cxx b/src/output/plugins/JackOutputPlugin.cxx
index d9c8634f4..4ce6a7a5e 100644
--- a/src/output/plugins/JackOutputPlugin.cxx
+++ b/src/output/plugins/JackOutputPlugin.cxx
@@ -419,7 +419,7 @@ JackOutput::Connect()
}
static bool
-mpd_jack_test_default_device(void)
+mpd_jack_test_default_device()
{
return true;
}
diff --git a/src/output/plugins/PulseOutputPlugin.cxx b/src/output/plugins/PulseOutputPlugin.cxx
index 7bc4f3c31..2ae5a7d41 100644
--- a/src/output/plugins/PulseOutputPlugin.cxx
+++ b/src/output/plugins/PulseOutputPlugin.cxx
@@ -872,7 +872,7 @@ try {
}
static bool
-pulse_output_test_default_device(void)
+pulse_output_test_default_device()
{
return PulseOutput::TestDefaultDevice();
}
diff --git a/src/unix/Daemon.cxx b/src/unix/Daemon.cxx
index 1aea2034e..d20f7d7e1 100644
--- a/src/unix/Daemon.cxx
+++ b/src/unix/Daemon.cxx
@@ -66,7 +66,7 @@ static bool had_group = false;
static int detach_fd = -1;
void
-daemonize_kill(void)
+daemonize_kill()
{
if (pidfile.IsNull())
throw std::runtime_error("no pid_file specified in the config file");
@@ -85,14 +85,14 @@ daemonize_kill(void)
}
void
-daemonize_close_stdin(void)
+daemonize_close_stdin()
{
close(STDIN_FILENO);
open("/dev/null", O_RDONLY);
}
void
-daemonize_set_user(void)
+daemonize_set_user()
{
if (user_name == nullptr)
return;
@@ -245,7 +245,7 @@ daemonize_init(const char *user, const char *group, AllocatedPath &&_pidfile)
}
void
-daemonize_finish(void)
+daemonize_finish()
{
if (!pidfile.IsNull()) {
unlink(pidfile.c_str());