From 541da2740d39ede4fe62739c93238525c8f6cd1b Mon Sep 17 00:00:00 2001 From: Steven OBrien Date: Wed, 23 Nov 2016 17:30:30 +0100 Subject: [PATCH] db/simple: add missing "return" SimpleDatabase::Visit() always throws exception when visiting a song. Adding a song to the queue always results in a "No such directory" error response, although the song is successfully added. This behaviour was introduced by commit 3ff728ab02644ac4f84d4bc931ade91fc0667cc8. This patch fixes this. https://bugs.musicpd.org/view.php?id=4601 --- src/db/plugins/simple/SimpleDatabasePlugin.cxx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/db/plugins/simple/SimpleDatabasePlugin.cxx b/src/db/plugins/simple/SimpleDatabasePlugin.cxx index 4006b54cf..fee196588 100644 --- a/src/db/plugins/simple/SimpleDatabasePlugin.cxx +++ b/src/db/plugins/simple/SimpleDatabasePlugin.cxx @@ -289,6 +289,8 @@ SimpleDatabase::Visit(const DatabaseSelection &selection, const LightSong song2 = song->Export(); if (selection.Match(song2)) visit_song(song2); + + return; } } }