From 27193d84026dca7dce8e864da5a703e203347cdc Mon Sep 17 00:00:00 2001 From: Max Kellermann Date: Sat, 7 Mar 2009 23:48:28 +0100 Subject: [PATCH] output_all: fix boolean short circuit in update() Sometimes, audio_output_update() isn't called for the second device when the first one has succeeded. The patch "audio_output_all_update() returns bool" broke it, because the boolean evaluation ended after the first "true". --- src/output_all.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/output_all.c b/src/output_all.c index eca4d191c..7b308a428 100644 --- a/src/output_all.c +++ b/src/output_all.c @@ -178,8 +178,8 @@ audio_output_all_update(void) return false; for (i = 0; i < num_audio_outputs; ++i) - ret = ret || audio_output_update(&audio_outputs[i], - &input_audio_format); + ret = audio_output_update(&audio_outputs[i], + &input_audio_format) || ret; return ret; }