From 24fa3f5e7bf01f14f0627cedad5c949efcfe9c5f Mon Sep 17 00:00:00 2001 From: Max Kellermann Date: Sat, 14 May 2016 12:29:53 +0200 Subject: [PATCH] Revert "decoder/Thread: flush last chunk only on success" This reverts commit 995cd95474971bb14a931f88607b3d00763179f6. It was a bad idea because it caused assertion failures when a decoder plugin aborted with an exception. --- src/decoder/DecoderThread.cxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/decoder/DecoderThread.cxx b/src/decoder/DecoderThread.cxx index bb497a13f..a99d73472 100644 --- a/src/decoder/DecoderThread.cxx +++ b/src/decoder/DecoderThread.cxx @@ -406,7 +406,7 @@ decoder_run_song(DecoderControl &dc, /* flush the last chunk */ - if (success && decoder.chunk != nullptr) + if (decoder.chunk != nullptr) decoder.FlushChunk(); }