From 24afdee35ce3ed64823ead05930d452f0fb9e98a Mon Sep 17 00:00:00 2001 From: Max Kellermann Date: Thu, 30 Apr 2020 13:07:42 +0200 Subject: [PATCH] command/all: "tagtypes" requires no permissions The command is used to configure the client's connection, and this shouldn't require any permissions. The client should be able to do that before sending a password. --- NEWS | 2 ++ src/command/AllCommands.cxx | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 25181d973..0836c5ce8 100644 --- a/NEWS +++ b/NEWS @@ -1,4 +1,6 @@ ver 0.21.24 (not yet released) +* protocol + - "tagtypes" requires no permissions * fix unit test failure ver 0.21.23 (2020/04/23) diff --git a/src/command/AllCommands.cxx b/src/command/AllCommands.cxx index 7926b7128..3fb305527 100644 --- a/src/command/AllCommands.cxx +++ b/src/command/AllCommands.cxx @@ -193,7 +193,7 @@ static constexpr struct command commands[] = { { "subscribe", PERMISSION_READ, 1, 1, handle_subscribe }, { "swap", PERMISSION_CONTROL, 2, 2, handle_swap }, { "swapid", PERMISSION_CONTROL, 2, 2, handle_swapid }, - { "tagtypes", PERMISSION_READ, 0, -1, handle_tagtypes }, + { "tagtypes", PERMISSION_NONE, 0, -1, handle_tagtypes }, { "toggleoutput", PERMISSION_ADMIN, 1, 1, handle_toggleoutput }, #ifdef ENABLE_DATABASE { "unmount", PERMISSION_ADMIN, 1, 1, handle_unmount },