From c53d655045d2c792fd2f190beec96c05c7345f06 Mon Sep 17 00:00:00 2001 From: Jayden Bailey Date: Tue, 11 Sep 2018 18:45:05 +0100 Subject: [PATCH] Detect null edits and do nothing --- src/MediawikiDiscord.php | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/src/MediawikiDiscord.php b/src/MediawikiDiscord.php index 23b23aa..fa99746 100644 --- a/src/MediawikiDiscord.php +++ b/src/MediawikiDiscord.php @@ -79,30 +79,28 @@ final class MediawikiDiscordHooks { static function onPageContentSaveComplete ($wikiPage, $user, $content, $summary, $isMinor, $isWatch, $section, $flags, $revision, $status, $baseRevId) { - if (MediawikiDiscord::isNotificationExcluded("onPageContentSaveComplete")) - { + if (MediawikiDiscord::isNotificationExcluded("onPageContentSaveComplete")) { return; } - if ($status->value['new'] == true) //page is just created, there is no need to trigger second notification - { + if ($status->value['new'] == true) { // Page was just created, there is no need to trigger second notification return; } - - if ($isMinor) - { + + if ( !$revision || is_null( $status->getValue()['revision'] ) ) { // Edit was a null edit + return; + } + + if ($isMinor) { $messageTranslationKey = "onPageContentSaveComplete_MinorEdit"; - } - else - { + } else { $messageTranslationKey = "onPageContentSaveComplete"; } $message = MediawikiDiscord::translate($messageTranslationKey, MediawikiDiscord::getUserText($user), MediawikiDiscord::getPageText($wikiPage)); - if (empty($summary) == false) - { + if (empty($summary) == false) { $message .= sprintf(" `%s`", $summary); }