From 0846255a0bd877d595b0d636d6e4e471890ecee0 Mon Sep 17 00:00:00 2001 From: Szmyk Date: Tue, 31 Jul 2018 13:01:54 +0200 Subject: [PATCH] Remove multiple calls of WikiPage::getTitle() --- src/MediawikiDiscord.php | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/MediawikiDiscord.php b/src/MediawikiDiscord.php index 7d1a15e..1a2cc9c 100644 --- a/src/MediawikiDiscord.php +++ b/src/MediawikiDiscord.php @@ -18,20 +18,22 @@ final class MediawikiDiscord static function getPageText ($wikiPage, $links = true) { - $pageUrl = $wikiPage->getTitle()->getFullURL(); + $title = $wikiPage->getTitle(); + + $pageUrl = $title->getFullURL(); - $pageLink = MediawikiDiscordUtils::CreateMarkdownLink ($wikiPage->getTitle()->getFullText(), $pageUrl); + $pageLink = MediawikiDiscordUtils::CreateMarkdownLink ($title->getFullText(), $pageUrl); if ($links == true) { $revisionId = $wikiPage->getRevision()->getID(); - $editLink = MediawikiDiscordUtils::CreateMarkdownLink (MediawikiDiscord::translate("tags-edit"), $wikiPage->getTitle()->getFullUrl("action=edit")); - $historyLink = MediawikiDiscordUtils::CreateMarkdownLink (MediawikiDiscord::translate("hist"), $wikiPage->getTitle()->getFullUrl("action=history")); + $editLink = MediawikiDiscordUtils::CreateMarkdownLink (MediawikiDiscord::translate("tags-edit"), $title->getFullUrl("action=edit")); + $historyLink = MediawikiDiscordUtils::CreateMarkdownLink (MediawikiDiscord::translate("hist"), $title->getFullUrl("action=history")); // need to use arrays here for the second parameter since mediawiki doesn't allow more than two query string parameters, but you can use arrays to specify more. - $diffLink = MediawikiDiscordUtils::CreateMarkdownLink (MediawikiDiscord::translate("diff"), $wikiPage->getTitle()->getFullUrl("diff=prev", array("oldid" => $revisionId))); - $undoLink = MediawikiDiscordUtils::CreateMarkdownLink (MediawikiDiscord::translate("editundo"), $wikiPage->getTitle()->getFullUrl("action=edit", array("undoafter" => (int)($revisionId - 1), "undo" => $revisionId))); + $diffLink = MediawikiDiscordUtils::CreateMarkdownLink (MediawikiDiscord::translate("diff"), $title->getFullUrl("diff=prev", array("oldid" => $revisionId))); + $undoLink = MediawikiDiscordUtils::CreateMarkdownLink (MediawikiDiscord::translate("editundo"), $title->getFullUrl("action=edit", array("undoafter" => (int)($revisionId - 1), "undo" => $revisionId))); return sprintf("%s (%s | %s | %s | %s)", $pageLink, $editLink, $historyLink, $diffLink, $undoLink); }