From ff18c32ae4b1f70151627f6d96bb9278aac1eb81 Mon Sep 17 00:00:00 2001 From: Jeffrey Altman Date: Sun, 16 Jan 2022 23:10:33 -0500 Subject: [PATCH] lib/gssapi/ntlm: from_file do not leak 'f' on error Change-Id: Ica774bc3c156c384a2cf7084259d31f445d24a7d --- lib/gssapi/ntlm/init_sec_context.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/lib/gssapi/ntlm/init_sec_context.c b/lib/gssapi/ntlm/init_sec_context.c index 7172c588b..9a90f2975 100644 --- a/lib/gssapi/ntlm/init_sec_context.c +++ b/lib/gssapi/ntlm/init_sec_context.c @@ -61,17 +61,20 @@ from_file(const char *fn, const char *target_domain, if (d && target_domain != NULL && strcasecmp(target_domain, d) != 0) continue; *domainp = strdup(d); - if (*domainp == NULL) + if (*domainp == NULL) { + fclose(f); return ENOMEM; + } u = strtok_r(NULL, ":", &str); p = strtok_r(NULL, ":", &str); if (u == NULL || p == NULL) continue; *usernamep = strdup(u); - if (*usernamep == NULL) + if (*usernamep == NULL) { + fclose(f); return ENOMEM; - + } heim_ntlm_nt_key(p, key); memset_s(buf, sizeof(buf), 0, sizeof(buf));