From f6e5c6cbae276ace660a89e90d44155763821804 Mon Sep 17 00:00:00 2001
From: Assar Westerlund <assar@sics.se>
Date: Sun, 11 Apr 1999 22:53:45 +0000
Subject: [PATCH] (init_tgs_req): some more error checking

git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@5939 ec53bebd-3082-4978-b11e-865c3cabbd6b
---
 lib/krb5/get_cred.c | 28 ++++++++++++++++++++--------
 1 file changed, 20 insertions(+), 8 deletions(-)

diff --git a/lib/krb5/get_cred.c b/lib/krb5/get_cred.c
index c7992e3e2..25a5c9f08 100644
--- a/lib/krb5/get_cred.c
+++ b/lib/krb5/get_cred.c
@@ -142,6 +142,7 @@ init_tgs_req (krb5_context context,
     t->msg_type = krb_tgs_req;
     if (in_creds->session.keytype) {
 	krb5_enctype foo[2];
+
 	foo[0] = in_creds->session.keytype;
 	foo[1] = 0;
 	ret = krb5_init_etype(context,
@@ -209,21 +210,30 @@ init_tgs_req (krb5_context context,
     {
 	krb5_auth_context ac;
 	krb5_keyblock *key;
+
 	ret = krb5_auth_con_init(context, &ac);
 	if(ret)
-	    return ret;
+	    goto fail;
 	ret = krb5_generate_subkey (context, &krbtgt->session, &key);
+	if (ret) {
+	    krb5_auth_con_free (context, ac);
+	    goto fail;
+	}
 	ret = krb5_auth_con_setlocalsubkey(context, ac, key);
-	if(ret == ENOMEM)
-	    /* XXX */;
+	if (ret) {
+	    krb5_free_keyblock (context, key);
+	    krb5_auth_con_free (context, ac);
+	    goto fail;
+	}
 
-	if(in_creds->authdata.len){
+	if(in_creds->authdata.len) {
 	    size_t len;
 	    unsigned char *buf;
 	    krb5_crypto crypto;
 	    len = length_AuthorizationData(&in_creds->authdata);
 	    buf = malloc(len);
-	    ret = encode_AuthorizationData(buf + len - 1, len, &in_creds->authdata, &len);
+	    ret = encode_AuthorizationData(buf + len - 1,
+					   len, &in_creds->authdata, &len);
 	    ALLOC(t->req_body.enc_authorization_data, 1);
 	    ret = krb5_crypto_init(context, key, 0, &crypto);
 	    krb5_encrypt_EncryptedData(context, 
@@ -235,17 +245,19 @@ init_tgs_req (krb5_context context,
 				       0,
 				       t->req_body.enc_authorization_data);
 	    krb5_crypto_destroy(context, crypto);
-	}else
+	} else {
 	    t->req_body.enc_authorization_data = NULL;
+	}
     
-
 	ret = make_pa_tgs_req(context,
 			      ac,
 			      &t->req_body, 
 			      t->padata->val,
 			      krbtgt);
-	if(ret)
+	if(ret) {
+	    krb5_auth_con_free(context, ac);
 	    goto fail;
+	}
 	*subkey = key;
 	
 	krb5_auth_con_free(context, ac);