From f6d26bce66d38b50f9f61d4794be1f272942da2a Mon Sep 17 00:00:00 2001 From: Joseph Sutton Date: Fri, 29 Apr 2022 12:05:50 +1200 Subject: [PATCH] kadm5: Correctly set userAccountControl bits We meant to clear only the UF_SMARTCARD_REQUIRED bit, but we were instead clearing all bits excepting it. Signed-off-by: Joseph Sutton --- lib/kadm5/ad.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/kadm5/ad.c b/lib/kadm5/ad.c index d606cd89f..b9b9c9023 100644 --- a/lib/kadm5/ad.c +++ b/lib/kadm5/ad.c @@ -1196,7 +1196,7 @@ kadm5_ad_modify_principal(void *server_handle, if (entry->attributes & KRB5_KDB_REQUIRES_HW_AUTH) i |= UF_SMARTCARD_REQUIRED; else - i &= UF_SMARTCARD_REQUIRED; + i &= ~UF_SMARTCARD_REQUIRED; if (entry->attributes & KRB5_KDB_DISALLOW_SVR) i &= ~UF_WORKSTATION_TRUST_ACCOUNT; else