From e020dc25b8f02bb38d1197ec95dcb0a9f2bfdd7c Mon Sep 17 00:00:00 2001 From: Nicolas Williams Date: Tue, 19 Jul 2011 21:14:15 -0500 Subject: [PATCH] Fix a double free in ank.c. --- kadmin/ank.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/kadmin/ank.c b/kadmin/ank.c index 1b7bab7b5..c8e429f53 100644 --- a/kadmin/ank.c +++ b/kadmin/ank.c @@ -163,7 +163,6 @@ add_one_principal (const char *name, princ.kvno = 1; kadm5_modify_principal(kadm_handle, &princ, KADM5_ATTRIBUTES | KADM5_KVNO); - kadm5_free_principal_ent(kadm_handle, &princ); } else if (key_data) { ret = kadm5_chpass_principal_with_key (kadm_handle, princ_ent, 3, key_data); @@ -174,7 +173,6 @@ add_one_principal (const char *name, KADM5_PRINCIPAL | KADM5_ATTRIBUTES); princ.attributes &= (~KRB5_KDB_DISALLOW_ALL_TIX); kadm5_modify_principal(kadm_handle, &princ, KADM5_ATTRIBUTES); - kadm5_free_principal_ent(kadm_handle, &princ); } else if (rand_password) { char *princ_name; @@ -183,8 +181,7 @@ add_one_principal (const char *name, free (princ_name); } out: - if (princ_ent) - krb5_free_principal (context, princ_ent); + kadm5_free_principal_ent(kadm_handle, &princ); /* frees princ_ent */ if(default_ent) kadm5_free_principal_ent (kadm_handle, default_ent); if (password != NULL)