diff --git a/appl/ftp/ftp/domacro.c b/appl/ftp/ftp/domacro.c index ba518c3a4..ecfe5ae16 100644 --- a/appl/ftp/ftp/domacro.c +++ b/appl/ftp/ftp/domacro.c @@ -123,7 +123,7 @@ TOP: if (bell && c->c_bell) { putchar('\007'); } - strcpy(line, line2); + strlcpy(line, line2, sizeof(line)); makeargv(); argc = margc; argv = margv; diff --git a/kuser/klist.c b/kuser/klist.c index 37ca7889f..5b39a012a 100644 --- a/kuser/klist.c +++ b/kuser/klist.c @@ -40,7 +40,7 @@ static char* printable_time(time_t t) { static char s[128]; - strcpy(s, ctime(&t)+ 4); + strlcpy(s, ctime(&t)+ 4, sizeof(s)); s[15] = 0; return s; } @@ -49,7 +49,7 @@ static char* printable_time_long(time_t t) { static char s[128]; - strcpy(s, ctime(&t)+ 4); + strlcpy(s, ctime(&t)+ 4, sizeof(s)); s[20] = 0; return s; } diff --git a/lib/kadm5/dump_log.c b/lib/kadm5/dump_log.c index b59640fbc..0ef30084b 100644 --- a/lib/kadm5/dump_log.c +++ b/lib/kadm5/dump_log.c @@ -130,7 +130,7 @@ print_entry(kadm5_server_context *server_context, } if(mask & KADM5_PRINC_EXPIRE_TIME) { if(ent.valid_end == NULL) { - strcpy(t, "never"); + strlcpy(t, "never", sizeof(t)); } else { strftime(t, sizeof(t), "%Y-%m-%d %H:%M:%S", localtime(ent.valid_end)); @@ -139,7 +139,7 @@ print_entry(kadm5_server_context *server_context, } if(mask & KADM5_PW_EXPIRATION) { if(ent.pw_end == NULL) { - strcpy(t, "never"); + strlcpy(t, "never", sizeof(t)); } else { strftime(t, sizeof(t), "%Y-%m-%d %H:%M:%S", localtime(ent.pw_end)); @@ -155,14 +155,14 @@ print_entry(kadm5_server_context *server_context, } if(mask & KADM5_MAX_LIFE) { if(ent.max_life == NULL) - strcpy(t, "for ever"); + strlcpy(t, "for ever", sizeof(t)); else unparse_time(*ent.max_life, t, sizeof(t)); printf(" max life = %s\n", t); } if(mask & KADM5_MAX_RLIFE) { if(ent.max_renew == NULL) - strcpy(t, "for ever"); + strlcpy(t, "for ever", sizeof(t)); else unparse_time(*ent.max_renew, t, sizeof(t)); printf(" max rlife = %s\n", t);