From cf020532c2dae5861d4ba452b94964d4cbe1aeda Mon Sep 17 00:00:00 2001 From: Nicolas Williams Date: Wed, 30 Nov 2022 09:32:54 -0600 Subject: [PATCH] bx509d: Fix leak of error messages --- kdc/bx509d.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/kdc/bx509d.c b/kdc/bx509d.c index 4d1b694a9..8bd085e75 100644 --- a/kdc/bx509d.c +++ b/kdc/bx509d.c @@ -1991,10 +1991,13 @@ get_tgts_accumulate_ccache_write_json(struct bx509_request_desc *r, ret = heim_dict_set_value(o, k, v); } if (ret == 0 && code != 0) { + const char *s = krb5_get_error_message(r->context, code); + heim_release(v); heim_release(k); k = heim_string_create("error"); - v = heim_string_create(krb5_get_error_message(r->context, code)); + v = heim_string_create(s ? s : "Out of memory"); + krb5_free_error_message(r->context, s); if (k && v) ret = heim_dict_set_value(o, k, v); }