From c9d390acac89be1a2eb46a202cb3489bb72756a0 Mon Sep 17 00:00:00 2001 From: Nicolas Williams Date: Tue, 13 Aug 2013 23:32:16 -0500 Subject: [PATCH] Don't use "if (!ret)" --- kuser/kinit.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/kuser/kinit.c b/kuser/kinit.c index 9e6185de8..df37d3e76 100644 --- a/kuser/kinit.c +++ b/kuser/kinit.c @@ -637,11 +637,12 @@ get_new_tickets(krb5_context context, int aret = 0; ret = krb5_unparse_name(context, principal, &p); - if (!ret) { - aret = asprintf(&prompt, N_("%s's Password: ", ""), p); - free(p); - } - if (ret || aret == -1) + if (ret) + errx(1, "failed to generate passwd prompt: not enough memory"); + + aret = asprintf(&prompt, N_("%s's Password: ", ""), p); + free(p); + if (aret == -1) errx(1, "failed to generate passwd prompt: not enough memory"); if (UI_UTIL_read_pw_string(passwd, sizeof(passwd)-1, prompt, 0)){